Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: make gRPC connections synced #52051

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Mar 25, 2024

What problem does this PR solve?

Issue Number: close #52049

Problem Summary:
See the issue.

What changed and how does it work?

This added a mutex for each stream.

Check List

Tests

  • Unit test
    This reuses the unit test before.
    It should be transparent.
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Yu Juncen <yu745514916@live.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2024
Copy link

tiprow bot commented Mar 25, 2024

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YuJuncen YuJuncen added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Merging #52051 (385205f) into master (9b6db9d) will decrease coverage by 16.1203%.
Report is 69 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52051         +/-   ##
=================================================
- Coverage   70.7435%   54.6233%   -16.1203%     
=================================================
  Files          1477       1597        +120     
  Lines        438550     625577     +187027     
=================================================
+ Hits         310246     341711      +31465     
- Misses       108884     260168     +151284     
- Partials      19420      23698       +4278     
Flag Coverage Δ
integration 36.6367% <69.2307%> (?)
unit 70.4313% <92.3076%> (-0.1117%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.5018% <100.0000%> (+4.6733%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 25, 2024
Copy link

ti-chi-bot bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 25, 2024
Copy link

ti-chi-bot bot commented Mar 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-25 06:02:07.910455501 +0000 UTC m=+1874954.932701884: ☑️ agreed by Leavrth.
  • 2024-03-25 12:32:35.844130743 +0000 UTC m=+1898382.866377129: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot merged commit 02b277a into pingcap:master Mar 25, 2024
35 of 47 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #52081.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 25, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Mar 26, 2024
@BornChanger
Copy link
Contributor

/lable needs-cherry-pick-release-7,1

@BornChanger
Copy link
Contributor

/label needs-cherry-pick-release-7.5

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Apr 12, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #52556.

@BornChanger BornChanger added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Apr 12, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 12, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52557.

YuJuncen added a commit to YuJuncen/tidb that referenced this pull request May 6, 2024
mittalrishabh pushed a commit to mittalrishabh/tidb that referenced this pull request May 6, 2024
…ingcap#64)

close pingcap#52049

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
mittalrishabh pushed a commit to mittalrishabh/tidb that referenced this pull request May 30, 2024
close pingcap#52049

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disk_snapshot_backup: init pod may get stuck due to concurrency call to Send
4 participants