-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disk_snapshot_backup: init pod may get stuck due to concurrency call to Send
#52049
Labels
affects-6.5
affects-7.1
affects-7.5
affects-8.1
component/br
This issue is related to BR of TiDB.
severity/major
type/bug
The issue is confirmed as a bug.
Comments
13 tasks
ti-chi-bot
bot
added
may-affects-5.4
This bug maybe affects 5.4.x versions.
may-affects-6.1
may-affects-7.1
may-affects-7.5
labels
Mar 25, 2024
YuJuncen
added
affects-7.1
affects-7.5
and removed
may-affects-5.4
This bug maybe affects 5.4.x versions.
may-affects-6.1
may-affects-7.1
may-affects-7.5
affects-7.1
affects-7.5
labels
Mar 25, 2024
13 tasks
This was referenced Apr 12, 2024
YuJuncen
added a commit
to YuJuncen/tidb
that referenced
this issue
May 6, 2024
12 tasks
mittalrishabh
pushed a commit
to mittalrishabh/tidb
that referenced
this issue
May 6, 2024
…ingcap#64) close pingcap#52049 Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
mittalrishabh
pushed a commit
to mittalrishabh/tidb
that referenced
this issue
May 30, 2024
close pingcap#52049 Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-6.5
affects-7.1
affects-7.5
affects-8.1
component/br
This issue is related to BR of TiDB.
severity/major
type/bug
The issue is confirmed as a bug.
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
Run a disk snapshot backup in a cluster that huge enough.
(Or just injecting some failpoints that make sometimes renewing the lease and sending wait apply happens concurrently.
2. What did you expect to see? (Required)
It should success to prepare -- nothing wrong happens.
3. What did you see instead (Required)
We were stuck at sending wait apply. When applying for quotas.
4. What is your TiDB version? (Required)
v6.5.x
But this may still happen in master.
NOTE
We call
Send
concurrently over a stream. Which isn't safe according to the document ofClientStream
:The text was updated successfully, but these errors were encountered: