-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br/operator: fix adapt env for snapshot backup stuck when encountered error (#52607) #56717
br/operator: fix adapt env for snapshot backup stuck when encountered error (#52607) #56717
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #56717 +/- ##
================================================
Coverage ? 71.1923%
================================================
Files ? 1466
Lines ? 423218
Branches ? 0
================================================
Hits ? 301299
Misses ? 101408
Partials ? 20511
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
Co-authored-by: BornChanger <97348524+BornChanger@users.noreply.github.com>
2d4c442
to
af4cab2
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #52607
What problem does this PR solve?
Issue Number: close #52049
Problem Summary:
When we failed to prepare the connections for wait apply, the channel may never be closed. Hence the pause PD operation (which relies on the finishing of the prepare connections stage) get stuck.
What changed and how does it work?
Selected over the context so it can be canceled.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.