-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br/operator: fix stuck when terminating #52264
Conversation
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Yu Juncen <yu745514916@live.com>
|
/test check-dev |
@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52264 +/- ##
================================================
+ Coverage 70.8036% 72.1938% +1.3901%
================================================
Files 1491 1491
Lines 440446 440468 +22
================================================
+ Hits 311852 317991 +6139
+ Misses 109197 102240 -6957
- Partials 19397 20237 +840
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-check-issue-triage-complete |
/run-check-issue-triage-complete |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/label needs-cherry-pick-release-6.5 |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
… (pingcap#87) close pingcap#52243 Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #52243
Problem Summary:
When exiting due to error, we are waiting from the client to finish before receiving from the output channel. In this case, the output channel may be full and blocks the exit procedure.
What changed and how does it work?
We will poll from both the request exit result and the exit channel.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.