Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br/operator: fix stuck when terminating #52264

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Apr 1, 2024

What problem does this PR solve?

Issue Number: close #52243

Problem Summary:
When exiting due to error, we are waiting from the client to finish before receiving from the output channel. In this case, the output channel may be full and blocks the exit procedure.

What changed and how does it work?

We will poll from both the request exit result and the exit channel.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed an issue where init pod may get stuck when encountering connective errors.

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2024
Copy link

tiprow bot commented Apr 1, 2024

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Yu Juncen <yu745514916@live.com>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2024
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Apr 1, 2024

/test check-dev

@YuJuncen
Copy link
Contributor Author

YuJuncen commented Apr 1, 2024

/test check-dev

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 1, 2024
@YuJuncen YuJuncen changed the title fix stuck when terminating br/operator: fix stuck when terminating Apr 1, 2024
Copy link

tiprow bot commented Apr 1, 2024

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Merging #52264 (4a54e01) into master (150233d) will increase coverage by 1.3902%.
The diff coverage is 87.0967%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52264        +/-   ##
================================================
+ Coverage   70.8036%   72.1938%   +1.3901%     
================================================
  Files          1491       1491                
  Lines        440446     440468        +22     
================================================
+ Hits         311852     317991      +6139     
+ Misses       109197     102240      -6957     
- Partials      19397      20237       +840     
Flag Coverage Δ
integration 23.1657% <32.2580%> (?)
unit 70.4780% <87.0967%> (-0.1461%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.3092% <87.0967%> (+5.4796%) ⬆️

@BornChanger
Copy link
Contributor

/retest

Copy link

tiprow bot commented Apr 2, 2024

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor

/run-check-issue-triage-complete

@YuJuncen
Copy link
Contributor Author

YuJuncen commented Apr 2, 2024

/run-check-issue-triage-complete

Copy link

ti-chi-bot bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 3, 2024
Copy link

ti-chi-bot bot commented Apr 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-01 02:14:22.183592613 +0000 UTC m=+237323.711133157: ☑️ agreed by Leavrth.
  • 2024-04-03 10:11:36.557416657 +0000 UTC m=+438758.084957203: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot merged commit bd59da1 into pingcap:master Apr 3, 2024
35 of 39 checks passed
@BornChanger
Copy link
Contributor

/label needs-cherry-pick-release-6.5

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Apr 7, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #52361.

@BornChanger BornChanger added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Apr 12, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 12, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52558.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 12, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #52559.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 17, 2024
YuJuncen added a commit to YuJuncen/tidb that referenced this pull request May 6, 2024
mittalrishabh pushed a commit to mittalrishabh/tidb that referenced this pull request May 30, 2024
… (pingcap#87)

close pingcap#52243

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants