Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br/operator: fix stuck when terminating (#52264) #52361

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52264

What problem does this PR solve?

Issue Number: close #52243

Problem Summary:
When exiting due to error, we are waiting from the client to finish before receiving from the output channel. In this case, the output channel may be full and blocks the exit procedure.

What changed and how does it work?

We will poll from both the request exit result and the exit channel.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed an issue where init pod may get stuck when encountering connective errors.

Signed-off-by: Yu Juncen <yu745514916@live.com>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Apr 7, 2024
@YuJuncen
Copy link
Contributor

/build

Signed-off-by: Yu Juncen <yu745514916@live.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 11, 2024
@YuJuncen
Copy link
Contributor

/test unit-test

Copy link

tiprow bot commented Apr 11, 2024

@YuJuncen: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@9815b45). Click here to learn what that means.
The diff coverage is 87.0967%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #52361   +/-   ##
================================================
  Coverage               ?   73.6409%           
================================================
  Files                  ?       1096           
  Lines                  ?     351542           
  Branches               ?          0           
================================================
  Hits                   ?     258879           
  Misses                 ?      76027           
  Partials               ?      16636           

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 17, 2024
Copy link

ti-chi-bot bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 17, 2024
Copy link

ti-chi-bot bot commented Apr 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-11 06:51:09.717686822 +0000 UTC m=+1117931.245227532: ☑️ agreed by Leavrth.
  • 2024-04-17 14:14:38.195167018 +0000 UTC m=+433897.306213468: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 17, 2024
@ti-chi-bot ti-chi-bot bot merged commit dc60697 into pingcap:release-6.5 Apr 17, 2024
22 checks passed
mittalrishabh pushed a commit to mittalrishabh/tidb that referenced this pull request May 30, 2024
… (pingcap#87)

close pingcap#52243

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants