Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix the issue that plan cache may return wrong result when comparing datetime column with unix_timestamp (#48413) #53266

Merged
merged 1 commit into from
May 14, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented May 14, 2024

This is a cherry-pick of #48413

What problem does this PR solve?

Issue Number: close #48165, close #41918

Problem Summary: planner: fix the issue that plan cache may return wrong result when comparing datetime column with unix_timestamp

What is changed and how it works?

planner: fix the issue that plan cache may return wrong result when comparing datetime column with unix_timestamp

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 14, 2024
Copy link

tiprow bot commented May 14, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 14, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 14, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 14, 2024
Copy link

ti-chi-bot bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented May 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-14 10:54:59.504182685 +0000 UTC m=+1564253.261318255: ☑️ agreed by hawkingrei.
  • 2024-05-14 11:02:44.580513375 +0000 UTC m=+1564718.337648947: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit da6dc8b into pingcap:release-7.1 May 14, 2024
7 checks passed
@qw4990 qw4990 added the type/bugfix This PR fixes a bug. label Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 56.66667% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.1@a3c139d). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #53266   +/-   ##
================================================
  Coverage               ?   73.4256%           
================================================
  Files                  ?       1211           
  Lines                  ?     380160           
  Branches               ?          0           
================================================
  Hits                   ?     279135           
  Misses                 ?      83188           
  Partials               ?      17837           
Flag Coverage Δ
unit 73.4256% <56.6666%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9582% <0.0000%> (?)
parser 85.0933% <0.0000%> (?)
br 52.7351% <0.0000%> (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants