-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: use the correct type when eval decimal and float session var (#51395) #53415
expression: use the correct type when eval decimal and float session var (#51395) #53415
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hi-rustin, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #53415 +/- ##
================================================
Coverage ? 71.9882%
================================================
Files ? 1411
Lines ? 410014
Branches ? 0
================================================
Hits ? 295162
Misses ? 94987
Partials ? 19865
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
This is an automated cherry-pick of #51395
What problem does this PR solve?
Issue Number: close #43527
Problem Summary:
What changed and how does it work?
In the SQL,
@total
type is int64, but when we do eval decimal we will directly convert it as decimal then we will get a panic because there is nox
for int value.GetMysqlDecimal:
ToDecimal:
So we have to try to convert it explicitly.
Same for the float value eval process. We also need to convert it.
Because #8412 disabled the vectorized execution of get or set variable, so we don't really execute that code right now. But I also updated it.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.