domain: splite handleDDLEvent into new thread #53734
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53734 +/- ##
=================================================
- Coverage 72.5980% 55.7310% -16.8671%
=================================================
Files 1506 1626 +120
Lines 431531 602137 +170606
=================================================
+ Hits 313283 335577 +22294
- Misses 98967 243422 +144455
- Partials 19281 23138 +3857
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
removed
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
labels
pkg/domain/domain.go
Outdated
| @@ -2250,6 +2250,10 @@ func (do *Domain) UpdateTableStatsLoop(ctx, initStatsCtx sessionctx.Context) err | |||
| // This is because the updated worker's primary responsibilities are to update the change delta and handle DDL operations. | |||
| // These tasks do not interfere with or depend on the initialization process. | |||
| do.wg.Run(func() { do.updateStatsWorker(ctx, owner) }, "updateStatsWorker") | |||
| do.wg.Run(func() { | |||
| <-do.StatsHandle().InitStatsDone | |||
There was a problem hiding this comment.
select with ctx to avoid dead wait?
There was a problem hiding this comment.
I have removed the logical that wait for init-stats.
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
lgtm
and removed
needs-1-more-lgtm
|
/cherrypick release-8.1 |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #53744
Problem Summary:
What changed and how does it work?
Now, handleDDlEvent is put into the goroutine which also handles
gcstatsand other works. so it cannot handle ddl event as soon as possible. it will lead to the problem. for example, If we cannot handle the CreateTable event promptly, this table hasn't the stats.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.