-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain: splite handleDDLEvent into new thread (#53734) #55276
domain: splite handleDDLEvent into new thread (#53734) #55276
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #55276 +/- ##
================================================
Coverage ? 73.4604%
================================================
Files ? 1211
Lines ? 380429
Branches ? 0
================================================
Hits ? 279465
Misses ? 83120
Partials ? 17844 |
This is an automated cherry-pick of #53734
What problem does this PR solve?
Issue Number: ref #53744
Problem Summary:
What changed and how does it work?
Now, handleDDlEvent is put into the goroutine which also handles
gcstats
and other works. so it cannot handle ddl event as soon as possible. it will lead to the problem. for example, If we cannot handle the CreateTable event promptly, this table hasn't the stats.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.