-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: reuse memory for parallelSortSpillHelper (#53859) #53879
executor: reuse memory for parallelSortSpillHelper (#53859) #53879
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #53879 +/- ##
================================================
Coverage ? 71.2449%
================================================
Files ? 1465
Lines ? 421787
Branches ? 0
================================================
Hits ? 300502
Misses ? 100854
Partials ? 20431
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
/cherrypick release-7.5 |
@hawkingrei: once the present PR merges, I will cherry-pick it on top of release-7.5 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #53859
What problem does this PR solve?
Issue Number: close #53861
Problem Summary:
What changed and how does it work?
we get a profiler while we benchmark sync load. it takes too much time on the newParallelSortSpillHelper. it is unnecessary.
https://flamegraph.com/share/4dca9137-2419-11ef-ab1b-b6898751f631
Check List
Tests
after optimization
t takes less time on the newParallelSortSpillHelper
https://flamegraph.com/share/822c3df8-247d-11ef-ab1b-b6898751f631
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.