-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: reuse memory for parallelSortSpillHelper (#53859) (#53879) #53890
executor: reuse memory for parallelSortSpillHelper (#53859) (#53879) #53890
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #53890 +/- ##
================================================
Coverage ? 72.0220%
================================================
Files ? 1411
Lines ? 410741
Branches ? 0
================================================
Hits ? 295824
Misses ? 95021
Partials ? 19896
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automated cherry-pick of #53879
This is an automated cherry-pick of #53859
What problem does this PR solve?
Issue Number: close #53861
Problem Summary:
What changed and how does it work?
we get a profiler while we benchmark sync load. it takes too much time on the newParallelSortSpillHelper. it is unnecessary.
https://flamegraph.com/share/4dca9137-2419-11ef-ab1b-b6898751f631
Check List
Tests
after optimization
t takes less time on the newParallelSortSpillHelper
https://flamegraph.com/share/822c3df8-247d-11ef-ab1b-b6898751f631
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.