executor: fix tidb crash when calling Close and Finish

[wshwsh12]

What problem does this PR solve?

Issue Number: close #54335

Problem Summary: ref #52882

What changed and how does it work?

1. Move the finishLock to tidbResultSet to protect Close() and Finish().
2. Clear SQLKiller.Finish() when writeResultSet finished.

Bug Analyze:
interface:resultSet.ResultSet           -> {RecordSet}       -> {RecordSet}
struct   :tidbResultSet                 -> execStmtResult   -> recordSet

calling chain:

main goroutine: tidbResultSet.Close  ->  execStmtResultSet.Close  ->  execStmtResultSet.Finish() 
                                                                 ->  recordSet.Close                -> recordSet.Finish()
                                                                                                    -> recordSet.CleanWork
                                                                 ->  execStmtResultSet.CleanWork
                                     -> tidbResultSet.CleanWork(race)


kill goroutine: tidbResultSet.Finish(race) ->  execStmtResultSet.Finish ->  recordSet.Finish

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @wshwsh12. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.7637%. Comparing base (e985478) to head (56df574).
Report is 14 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #54390         +/-   ##
=================================================
- Coverage   72.8299%   55.7637%   -17.0662%     
=================================================
  Files          1531       1654        +123     
  Lines        435995     612706     +176711     
=================================================
+ Hits         317535     341668      +24133     
- Misses        98818     247488     +148670     
- Partials      19642      23550       +3908     

Flag	Coverage Δ
integration	22.7289% <25.0000%> (?)
unit	71.8048% <92.5000%> (-0.0191%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <ø> (ø)
parser	∅ <ø> (∅)
br	52.6639% <ø> (+6.5274%)	⬆️

[wshwsh12]

/retest

[tiprow]

@wshwsh12: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [XuHuaiyu,guo-shaoge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-07-03 08:38:29.031790791 +0000 UTC m=+1400035.517279623: ☑️ agreed by guo-shaoge.
• 2024-07-03 08:56:53.340944316 +0000 UTC m=+1401139.826433147: ☑️ agreed by XuHuaiyu.

[wshwsh12]

/retest

[tiprow]

@wshwsh12: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.2: #54416.