-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix tidb crash when calling Close and Finish (#54390) #54416
executor: fix tidb crash when calling Close and Finish (#54390) #54416
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guo-shaoge, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.2 #54416 +/- ##
================================================
Coverage ? 55.8684%
================================================
Files ? 1639
Lines ? 606826
Branches ? 0
================================================
Hits ? 339024
Misses ? 244587
Partials ? 23215
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automated cherry-pick of #54390
What problem does this PR solve?
Issue Number: close #54335
Problem Summary: ref #52882
What changed and how does it work?
finishLock
totidbResultSet
to protect Close() and Finish().SQLKiller.Finish()
whenwriteResultSet
finished.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.