Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] mod: update the pd client #54457

Merged

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Jul 4, 2024

What problem does this PR solve?

Issue Number: ref #47421 ref tikv/pd#8349

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 4, 2024
@nolouch
Copy link
Member Author

nolouch commented Jul 4, 2024

/retest-required

glorv
glorv previously approved these changes Jul 4, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 4, 2024
@jebter
Copy link

jebter commented Jul 4, 2024

/retest

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.5-20240704-v7.5.2@3c02c2a). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-7.5-20240704-v7.5.2     #54457   +/-   ##
================================================================
  Coverage                               ?   72.0239%           
================================================================
  Files                                  ?       1411           
  Lines                                  ?     410741           
  Branches                               ?          0           
================================================================
  Hits                                   ?     295832           
  Misses                                 ?      95016           
  Partials                               ?      19893           
Flag Coverage Δ
unit 72.0239% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4821% <0.0000%> (?)

@jebter
Copy link

jebter commented Jul 5, 2024

/retest

@HuSharp
Copy link
Contributor

HuSharp commented Jul 5, 2024

/test all

Copy link

tiprow bot commented Jul 5, 2024

@HuSharp: No presubmit jobs available for pingcap/tidb@release-7.5-20240704-v7.5.2

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@HuSharp
Copy link
Contributor

HuSharp commented Jul 5, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 5, 2024
Copy link

ti-chi-bot bot commented Jul 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-04 12:59:09.745681671 +0000 UTC m=+1502076.231170495: ☑️ agreed by glorv.
  • 2024-07-05 01:55:18.107182207 +0000 UTC m=+1548644.592671039: ☑️ agreed by JmPotato.

@nolouch
Copy link
Member Author

nolouch commented Jul 5, 2024

/retest-required

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jul 5, 2024

/retest

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jul 5, 2024

/test build

Copy link

tiprow bot commented Jul 5, 2024

@wuhuizuo: No presubmit jobs available for pingcap/tidb@release-7.5-20240704-v7.5.2

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jul 5, 2024

/retest

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jul 5, 2024

/test check-dev

Copy link

tiprow bot commented Jul 5, 2024

@wuhuizuo: No presubmit jobs available for pingcap/tidb@release-7.5-20240704-v7.5.2

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
Copy link
Member Author

nolouch commented Jul 5, 2024

ptal again @glorv

Copy link

ti-chi-bot bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, JmPotato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit 387f691 into pingcap:release-7.5-20240704-v7.5.2 Jul 5, 2024
18 checks passed
@nolouch nolouch deleted the apply-issue-pd-8349 branch July 5, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants