Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource control quota maybe exceed in some scenarios #47421

Closed
lilinghai opened this issue Oct 7, 2023 · 2 comments
Closed

Resource control quota maybe exceed in some scenarios #47421

lilinghai opened this issue Oct 7, 2023 · 2 comments
Labels
affects-7.1 affects-7.5 affects-8.1 affects-8.2 component/pd severity/major type/bug The issue is confirmed as a bug.

Comments

@lilinghai
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

some workloads run together and set ru limit
tpcc 80k limit and the workload fluctuates around 80k, with a maximum reaching 88k.
It is somewhat related to the current implementation. When a request comes in, the RU consumption is added first, rather than after wait. In the case of tpcc, the write RU consumption is relatively high with request. It indicates a small peak, exceeding 10%.
img_v2_4f1b3c06-27da-40fb-b1f9-94cbd950dafg

2. What did you expect to see? (Required)

resource usage is under ru limit

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master
@lilinghai lilinghai added the type/bug The issue is confirmed as a bug. label Oct 7, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Oct 8, 2023
@nolouch
Copy link
Member

nolouch commented Nov 7, 2023

it can't go too far beyond the specified RU rate, so I think that's reasonable. Let me lower the bug level first.

@nolouch nolouch removed may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Nov 7, 2023
@nolouch
Copy link
Member

nolouch commented Dec 11, 2023 •
edited
Loading

It meets the expectations in the current implementation.

@nolouch nolouch closed this as completed Dec 11, 2023
@nolouch nolouch mentioned this issue Jul 3, 2024
Merged
5 tasks
@nolouch nolouch mentioned this issue Jul 4, 2024
Merged
5 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jul 4, 2024
@nolouch
mod: update pd client (#54424)
9f7441a 
ref tikv/pd#8349, ref #47421
This was referenced Jul 4, 2024
Merged
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jul 5, 2024
@nolouch
[cherry-pick] mod: update the pd client (#54457)
387f691 
ref tikv/pd#8349, ref #47421
ti-chi-bot bot pushed a commit that referenced this issue Jul 5, 2024
@ti-chi-bot
mod: update pd client (#54424) (#54461)
821e491 
ref tikv/pd#8349, ref #47421
@nolouch nolouch mentioned this issue Jul 5, 2024
Merged
5 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jul 5, 2024
@nolouch
[cherry-pick] mod: update the pd client (#54482)
eaff0fb 
ref tikv/pd#8349, ref #47421
ti-chi-bot bot pushed a commit that referenced this issue Jul 12, 2024
@ti-chi-bot
mod: update pd client (#54424) (#54459)
ed1e010 
ref tikv/pd#8349, ref #47421
ti-chi-bot bot pushed a commit that referenced this issue Jul 12, 2024
@ti-chi-bot
mod: update pd client (#54424) (#54460)
8737e7d 
ref tikv/pd#8349, ref #47421
ti-chi-bot bot pushed a commit that referenced this issue Jul 14, 2024
@ti-chi-bot
mod: update pd client (#54424) (#54458)
223032b 
ref tikv/pd#8349, ref #47421
@nolouch nolouch mentioned this issue Jul 25, 2024
Merged
3 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jul 25, 2024
@nolouch
mod: update pd-client to fix the resource limiter issue (#54898)
d12f841 
ref tikv/pd#8435, ref #47421
This was referenced Jul 25, 2024
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jul 26, 2024
@ti-chi-bot
mod: update pd-client to fix the resource limiter issue (#54898) (#54911
6faf156 
)

ref tikv/pd#8435, ref #47421
ti-chi-bot bot pushed a commit that referenced this issue Jul 30, 2024
@ti-chi-bot
mod: update pd-client to fix the resource limiter issue (#54898) (#54912
cfd1d3a 
)

ref tikv/pd#8435, ref #47421
ti-chi-bot bot pushed a commit that referenced this issue Nov 1, 2024
@ti-chi-bot
mod: update pd-client to fix the resource limiter issue (#54898) (#54910
1458465 
)

ref tikv/pd#8435, ref #47421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.1 affects-7.5 affects-8.1 affects-8.2 component/pd severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jebter @nolouch @lilinghai @ti-chi-bot