Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource control quota maybe exceed in some scenarios #47421

Closed
lilinghai opened this issue Oct 7, 2023 · 2 comments
Closed

Resource control quota maybe exceed in some scenarios #47421

lilinghai opened this issue Oct 7, 2023 · 2 comments

Comments

@lilinghai
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

some workloads run together and set ru limit
tpcc 80k limit and the workload fluctuates around 80k, with a maximum reaching 88k.
It is somewhat related to the current implementation. When a request comes in, the RU consumption is added first, rather than after wait. In the case of tpcc, the write RU consumption is relatively high with request. It indicates a small peak, exceeding 10%.
img_v2_4f1b3c06-27da-40fb-b1f9-94cbd950dafg

2. What did you expect to see? (Required)

resource usage is under ru limit

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master

@lilinghai lilinghai added the type/bug The issue is confirmed as a bug. label Oct 7, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Oct 8, 2023
@nolouch
Copy link
Member

nolouch commented Nov 7, 2023

it can't go too far beyond the specified RU rate, so I think that's reasonable. Let me lower the bug level first.

@nolouch nolouch removed may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Nov 7, 2023
@nolouch
Copy link
Member

nolouch commented Dec 11, 2023

It meets the expectations in the current implementation.

ti-chi-bot bot pushed a commit that referenced this issue Jul 5, 2024
ti-chi-bot bot pushed a commit that referenced this issue Jul 12, 2024
ti-chi-bot bot pushed a commit that referenced this issue Jul 12, 2024
ti-chi-bot bot pushed a commit that referenced this issue Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants