Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod: update pd client (#54424) #54460

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #54424

What problem does this PR solve?

Issue Number: ref #47421 ref tikv/pd#8349

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jul 4, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 4, 2024
5 tasks
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Jul 4, 2024
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
Copy link
Member

nolouch commented Jul 8, 2024

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 8, 2024
@nolouch
Copy link
Member

nolouch commented Jul 9, 2024

/retest-required

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@f40e38f). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #54460   +/-   ##
================================================
  Coverage               ?   71.3030%           
================================================
  Files                  ?       1465           
  Lines                  ?     422359           
  Branches               ?          0           
================================================
  Hits                   ?     301155           
  Misses                 ?     100774           
  Partials               ?      20430           
Flag Coverage Δ
unit 71.3030% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.0726% <0.0000%> (?)

@nolouch
Copy link
Member

nolouch commented Jul 9, 2024

/retest-required

@nolouch nolouch requested review from JmPotato and glorv July 12, 2024 09:17
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 12, 2024
Copy link

ti-chi-bot bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 12, 2024
Copy link

ti-chi-bot bot commented Jul 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-08 08:44:19.363048455 +0000 UTC m=+260756.598282568: ☑️ agreed by nolouch.
  • 2024-07-12 10:19:05.139598315 +0000 UTC m=+3567.130539782: ☑️ agreed by glorv.

@ti-chi-bot ti-chi-bot bot merged commit 8737e7d into pingcap:release-8.1 Jul 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants