Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] mod: update the pd client #54482

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Jul 5, 2024

What problem does this PR solve?

Issue Number: ref #47421 ref tikv/pd#8349

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 5, 2024
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch force-pushed the apply-issue-pd-8349-patch-2 branch from 70a9942 to 23aaa7a Compare July 5, 2024 10:54
@nolouch
Copy link
Member Author

nolouch commented Jul 5, 2024

/retest-required

@nolouch nolouch requested review from glorv and crazycs520 July 5, 2024 10:58
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 5, 2024
Copy link

ti-chi-bot bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, glorv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 5, 2024
Copy link

ti-chi-bot bot commented Jul 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-05 11:00:06.579427884 +0000 UTC m=+9703.814661995: ☑️ agreed by crazycs520.
  • 2024-07-05 11:09:14.606320384 +0000 UTC m=+10251.841554497: ☑️ agreed by glorv.

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.5-20240704-v7.5.2@387f691). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-7.5-20240704-v7.5.2     #54482   +/-   ##
================================================================
  Coverage                               ?   72.0215%           
================================================================
  Files                                  ?       1411           
  Lines                                  ?     410741           
  Branches                               ?          0           
================================================================
  Hits                                   ?     295822           
  Misses                                 ?      95024           
  Partials                               ?      19895           
Flag Coverage Δ
unit 72.0215% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4382% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit eaff0fb into pingcap:release-7.5-20240704-v7.5.2 Jul 5, 2024
18 checks passed
@nolouch nolouch deleted the apply-issue-pd-8349-patch-2 branch July 8, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants