Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/executor,tests: reset params in the PipelineWindow.Open (#54709) #55317

Open
wants to merge 1 commit into
base: release-6.1
Choose a base branch
from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #54709

What problem does this PR solve?

Issue Number: close #53600

Problem Summary:

What changed and how does it work?

Before this commit:

$ ./run-tests.sh -r executor/window
extracting statistics: s
building tidb-server binary: ./integrationtest_tidb-server
building portgenerator binary: ./portgenerator
building mysql-tester binary: ./mysql_tester
start tidb-server, log file: ./integration-test.out
tidb-server(PID: 56846) started
record result for case: "executor/window"
ERRO[0007] run test [executor/window] err: sql:select 1 from t_tjov where ( select t_tjov.c_tutmh1 as c0 from ( select nth_value(t_n.c_tf_us39fv, 1) over (partition by t_db8a.c_jr2kq78hqt order by t_n.c_mm8jnf) as c5 from t_db8a join t_n ) as tbl limit 1 );: run "select 1 from t_tjov where ( select t_tjov.c_tutmh1 as c0 from ( select nth_value(t_n.c_tf_us39fv, 1) over (partition by t_db8a.c_jr2kq78hqt order by t_n.c_mm8jnf) as c5 from t_db8a join t_n ) as tbl limit 1 );" at line 560 err Error 1105 (HY000): runtime error: index out of range [32] with length 32 

ERRO[0007] 1 tests failed                               
ERRO[0007] run test [executor/window] err: sql:select 1 from t_tjov where ( select t_tjov.c_tutmh1 as c0 from ( select nth_value(t_n.c_tf_us39fv, 1) over (partition by t_db8a.c_jr2kq78hqt order by t_n.c_mm8jnf) as c5 from t_db8a join t_n ) as tbl limit 1 );: run "select 1 from t_tjov where ( select t_tjov.c_tutmh1 as c0 from ( select nth_value(t_n.c_tf_us39fv, 1) over (partition by t_db8a.c_jr2kq78hqt order by t_n.c_mm8jnf) as c5 from t_db8a join t_n ) as tbl limit 1 );" at line 560 err Error 1105 (HY000): runtime error: index out of range [32] with length 32 

After this commit:
No error reported

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Reset the parameters in the Open method of pipelinedwindow to avoid unexpected errors caused by repeated open and close operations when pipelinedwindow is used as a child node of apply, which prevents reusing previous parameter values.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/execution SIG execution size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Aug 9, 2024
Copy link

ti-chi-bot bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign siddontang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Aug 9, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev f3796c2 link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 f3796c2 link true /test check-dev2
idc-jenkins-ci-tidb/build f3796c2 link true /test build
idc-jenkins-ci-tidb/mysql-test f3796c2 link true /test mysql-test
idc-jenkins-ci-tidb/unit-test f3796c2 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/execution SIG execution size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants