Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/executor,tests: reset params in the PipelineWindow.Open #54709

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

XuHuaiyu
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #53600

Problem Summary:

What changed and how does it work?

Before this commit:

$ ./run-tests.sh -r executor/window
extracting statistics: s
building tidb-server binary: ./integrationtest_tidb-server
building portgenerator binary: ./portgenerator
building mysql-tester binary: ./mysql_tester
start tidb-server, log file: ./integration-test.out
tidb-server(PID: 56846) started
record result for case: "executor/window"
ERRO[0007] run test [executor/window] err: sql:select 1 from t_tjov where ( select t_tjov.c_tutmh1 as c0 from ( select nth_value(t_n.c_tf_us39fv, 1) over (partition by t_db8a.c_jr2kq78hqt order by t_n.c_mm8jnf) as c5 from t_db8a join t_n ) as tbl limit 1 );: run "select 1 from t_tjov where ( select t_tjov.c_tutmh1 as c0 from ( select nth_value(t_n.c_tf_us39fv, 1) over (partition by t_db8a.c_jr2kq78hqt order by t_n.c_mm8jnf) as c5 from t_db8a join t_n ) as tbl limit 1 );" at line 560 err Error 1105 (HY000): runtime error: index out of range [32] with length 32 

ERRO[0007] 1 tests failed                               
ERRO[0007] run test [executor/window] err: sql:select 1 from t_tjov where ( select t_tjov.c_tutmh1 as c0 from ( select nth_value(t_n.c_tf_us39fv, 1) over (partition by t_db8a.c_jr2kq78hqt order by t_n.c_mm8jnf) as c5 from t_db8a join t_n ) as tbl limit 1 );: run "select 1 from t_tjov where ( select t_tjov.c_tutmh1 as c0 from ( select nth_value(t_n.c_tf_us39fv, 1) over (partition by t_db8a.c_jr2kq78hqt order by t_n.c_mm8jnf) as c5 from t_db8a join t_n ) as tbl limit 1 );" at line 560 err Error 1105 (HY000): runtime error: index out of range [32] with length 32 

After this commit:
No error reported

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Reset the parameters in the Open method of pipelinedwindow to avoid unexpected errors caused by repeated open and close operations when pipelinedwindow is used as a child node of apply, which prevents reusing previous parameter values.

…nedwindow to avoid unexpected errors caused by repeated open and close operations when pipelinedwindow is used as a child node of apply, which prevents reusing previous parameter values.
@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. sig/execution SIG execution labels Jul 18, 2024
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 18, 2024
Copy link

tiprow bot commented Jul 18, 2024

Hi @XuHuaiyu. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.7746%. Comparing base (d0c1ca1) to head (40bd011).
Report is 5 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #54709        +/-   ##
================================================
+ Coverage   72.8488%   75.7746%   +2.9257%     
================================================
  Files          1570       1607        +37     
  Lines        439488     473293     +33805     
================================================
+ Hits         320162     358636     +38474     
+ Misses        99607      93861      -5746     
- Partials      19719      20796      +1077     
Flag Coverage Δ
integration 50.1697% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.0967% <ø> (+6.2179%) ⬆️

@XuHuaiyu
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jul 19, 2024

@XuHuaiyu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@XuHuaiyu
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jul 19, 2024
@XuHuaiyu
Copy link
Contributor Author

/retest

1 similar comment
@XuHuaiyu
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added component/dumpling This is related to Dumpling of TiDB. sig/planner SIG: Planner and removed approved labels Jul 30, 2024
@ti-chi-bot ti-chi-bot bot added the approved label Jul 30, 2024
@XuHuaiyu XuHuaiyu removed component/dumpling This is related to Dumpling of TiDB. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 30, 2024
Copy link

ti-chi-bot bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [guo-shaoge,wshwsh12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 6, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 6, 2024
Copy link

ti-chi-bot bot commented Aug 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-18 06:45:48.131496494 +0000 UTC m=+509170.122437956: ☑️ agreed by wshwsh12.
  • 2024-08-06 09:45:25.462199168 +0000 UTC m=+345255.329298254: ☑️ agreed by guo-shaoge.

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 8, 2024
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Aug 8, 2024

/retest

1 similar comment
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Aug 8, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit a541a4f into pingcap:master Aug 8, 2024
23 checks passed
@XuHuaiyu XuHuaiyu added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Aug 9, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #55317.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 9, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #55318.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 9, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 9, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #55319.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #55320.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 9, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #55321.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/execution SIG execution size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

index out of range [1] with length 1 in executor.(*PipelinedWindowExec).getRow
4 participants