Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/executor,tests: reset params in the PipelineWindow.Open (#54709) #55320

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #54709

What problem does this PR solve?

Issue Number: close #53600

Problem Summary:

What changed and how does it work?

Before this commit:

$ ./run-tests.sh -r executor/window
extracting statistics: s
building tidb-server binary: ./integrationtest_tidb-server
building portgenerator binary: ./portgenerator
building mysql-tester binary: ./mysql_tester
start tidb-server, log file: ./integration-test.out
tidb-server(PID: 56846) started
record result for case: "executor/window"
ERRO[0007] run test [executor/window] err: sql:select 1 from t_tjov where ( select t_tjov.c_tutmh1 as c0 from ( select nth_value(t_n.c_tf_us39fv, 1) over (partition by t_db8a.c_jr2kq78hqt order by t_n.c_mm8jnf) as c5 from t_db8a join t_n ) as tbl limit 1 );: run "select 1 from t_tjov where ( select t_tjov.c_tutmh1 as c0 from ( select nth_value(t_n.c_tf_us39fv, 1) over (partition by t_db8a.c_jr2kq78hqt order by t_n.c_mm8jnf) as c5 from t_db8a join t_n ) as tbl limit 1 );" at line 560 err Error 1105 (HY000): runtime error: index out of range [32] with length 32 

ERRO[0007] 1 tests failed                               
ERRO[0007] run test [executor/window] err: sql:select 1 from t_tjov where ( select t_tjov.c_tutmh1 as c0 from ( select nth_value(t_n.c_tf_us39fv, 1) over (partition by t_db8a.c_jr2kq78hqt order by t_n.c_mm8jnf) as c5 from t_db8a join t_n ) as tbl limit 1 );: run "select 1 from t_tjov where ( select t_tjov.c_tutmh1 as c0 from ( select nth_value(t_n.c_tf_us39fv, 1) over (partition by t_db8a.c_jr2kq78hqt order by t_n.c_mm8jnf) as c5 from t_db8a join t_n ) as tbl limit 1 );" at line 560 err Error 1105 (HY000): runtime error: index out of range [32] with length 32 

After this commit:
No error reported

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Reset the parameters in the Open method of pipelinedwindow to avoid unexpected errors caused by repeated open and close operations when pipelinedwindow is used as a child node of apply, which prevents reusing previous parameter values.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/execution SIG execution size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.5@3edb7a3). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #55320   +/-   ##
================================================
  Coverage               ?   72.0277%           
================================================
  Files                  ?       1415           
  Lines                  ?     412513           
  Branches               ?          0           
================================================
  Hits                   ?     297124           
  Misses                 ?      95492           
  Partials               ?      19897           
Flag Coverage Δ
unit 72.0277% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8243% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.5412% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 26, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 27, 2024
Copy link

ti-chi-bot bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [guo-shaoge,wshwsh12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 27, 2024
Copy link

ti-chi-bot bot commented Sep 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-27 06:58:51.251090355 +0000 UTC m=+1808400.991514286: ☑️ agreed by wshwsh12.
  • 2024-09-27 07:01:47.542825027 +0000 UTC m=+1808577.283248967: ☑️ agreed by guo-shaoge.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Sep 27, 2024
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 29, 2024
@jebter
Copy link

jebter commented Sep 29, 2024

/test unit-test

Copy link

tiprow bot commented Sep 29, 2024

@jebter: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 02029fd into pingcap:release-7.5 Sep 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/execution SIG execution size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants