lightning: Change how the ID of taskCfg.TaskID is generated

[ei-sugimoto]

What problem does this PR solve?

If lightning was used in parallel, the function could report an error because the task ID used the current time to generate the ID.

Issue Number: close #55384

Problem Summary:

What changed and how does it work?

• using hashed uuid

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

Hi @ei-sugimoto. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

Hi @ei-sugimoto. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lance6716]

/ok-to-test

[lance6716]

/cc @D3Hunter

[lance6716]

Hi, please merge master branch. We have fixed a lightning CI failure in last commits.

[D3Hunter]

/retest

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.7542%. Comparing base (4eeeef8) to head (757ded4).
Report is 198 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #55505        +/-   ##
================================================
+ Coverage   72.9214%   74.7542%   +1.8327%     
================================================
  Files          1581       1603        +22     
  Lines        442336     450297      +7961     
================================================
+ Hits         322558     336616     +14058     
+ Misses        99970      92753      -7217     
- Partials      19808      20928      +1120     

Flag	Coverage Δ
integration	50.4607% <40.0000%> (?)
unit	71.8567% <ø> (-0.1444%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (ø)
parser	∅ <ø> (∅)
br	52.0039% <ø> (+6.7247%)	⬆️

[D3Hunter]

Details

seems integration test fail repeatably, please fix them

[lance6716]

/retest

[ei-sugimoto]

/retest

[ei-sugimoto]

Why does the pull-lightning-integration-test fail? was it affected by the code I modified ?
@lance6716

[lance6716]

Why does the pull-lightning-integration-test fail? was it affected by the code I modified ? @lance6716

I'm not sure. I'll try to reproduce CI failure in my local environment if you are not capable to fix them.

[ei-sugimoto]

Details

seems integration test fail repeatably, please fix them

I fixed them . Please review :)

[lance6716]

ptal @D3Hunter

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• lightning/OWNERS [D3Hunter,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-08-26 11:32:00.863114428 +0000 UTC m=+783515.997564544: ☑️ agreed by lance6716.
• 2024-08-26 11:52:44.224743923 +0000 UTC m=+784759.359194091: ☑️ agreed by D3Hunter.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #56256.

[joechenrh]

/cherry-pick release-7.1

[ti-chi-bot]

@joechenrh: new pull request created to branch release-7.1: #57018.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.