Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: Change how the ID of taskCfg.TaskID is generated #55505

Merged
merged 14 commits into from
Aug 26, 2024
Merged

lightning: Change how the ID of taskCfg.TaskID is generated #55505

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8a04267
lightning: Change how the ID of `taskCfg.TaskID` is generated
ei-sugimoto Aug 19, 2024
209e3f4
Merge pull request #1 from ei-sugimoto/master
ei-sugimoto Aug 21, 2024
4c04450
Merge branch 'master' into fix/modify-change-how-to-set-task-id
ei-sugimoto Aug 21, 2024
eac6b55
lightning: tmply check ci
ei-sugimoto Aug 21, 2024
24849a8
lightning: generate id using hashed uuid
ei-sugimoto Aug 22, 2024
d116cb9
Merge branch 'master' into fix/modify-change-how-to-set-task-id
ei-sugimoto Aug 22, 2024
eba8185
lightning: tmply check ci
ei-sugimoto Aug 22, 2024
b005a7f
lightning: make `taskID`goroutin-safe using mutex
ei-sugimoto Aug 23, 2024
b269d30
fix
ei-sugimoto Aug 23, 2024
79a55a8
delete blank column
ei-sugimoto Aug 23, 2024
1421105
fix
ei-sugimoto Aug 23, 2024
4d5ad89
using `rand/math`
ei-sugimoto Aug 26, 2024
4b793bc
Merge branch 'master' into fix/modify-change-how-to-set-task-id
ei-sugimoto Aug 26, 2024
757ded4
use ` "crypto/rand"`
ei-sugimoto Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lightning/pkg/server/lightning.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import (
"encoding/pem"
"fmt"
"io"
"math/big"
"net"
"net/http"
"net/http/pprof"
Expand Down Expand Up @@ -355,8 +356,12 @@ func (l *Lightning) RunOnceWithOptions(taskCtx context.Context, taskCfg *config.
if err := taskCfg.Adjust(taskCtx); err != nil {
return err
}
r, err := rand.Int(rand.Reader, big.NewInt(1<<63-1))
if err != nil {
return err
}
taskCfg.TaskID = r.Int64()

taskCfg.TaskID = time.Now().UnixNano()
failpoint.Inject("SetTaskID", func(val failpoint.Value) {
taskCfg.TaskID = int64(val.(int))
})
Expand Down