Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Truncate partition failpoint tests #56029

Merged
merged 133 commits into from
Nov 26, 2024

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Sep 11, 2024

What problem does this PR solve?

Issue Number: ref #55819

Problem Summary:
Added failure injection tests.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

mjonss added 30 commits May 31, 2024 16:52
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 20, 2024
@mjonss mjonss requested review from tangenta and removed request for winoros November 20, 2024 21:25
pkg/ddl/tests/partition/error_injection_test.go Outdated Show resolved Hide resolved
pkg/ddl/tests/partition/error_injection_test.go Outdated Show resolved Hide resolved
pkg/ddl/rollingback.go Outdated Show resolved Hide resolved
pkg/ddl/rollingback.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 25, 2024
Copy link

ti-chi-bot bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 26, 2024
Copy link

ti-chi-bot bot commented Nov 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-25 11:44:11.739455283 +0000 UTC m=+464039.359109797: ☑️ agreed by Defined2014.
  • 2024-11-26 02:26:44.360871917 +0000 UTC m=+516991.980526432: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 5d9c6e1 into pingcap:master Nov 26, 2024
26 of 27 checks passed
mjonss added a commit to mjonss/tidb that referenced this pull request Nov 26, 2024
@mjonss mjonss deleted the truncate-partition-failpoint-tests branch November 26, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants