Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Fix for TRUNCATE PARTITION and Global Index #57724

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Nov 26, 2024

What problem does this PR solve?

Issue Number: close #57721

Problem Summary:
There were issues with TRUNCATE PARTITION and Global indexes, no rollback and blocked writes during some stages.

What changed and how does it work?

Cherry pick of #55831 and #56029

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

No more partition wide write block during "delete only" and "delete reorganization" for TRUNCATE PARTITION

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 26, 2024
@mjonss mjonss requested a review from Defined2014 November 26, 2024 11:22
Copy link

tiprow bot commented Nov 26, 2024

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 74.31907% with 66 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@aca349f). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #57724   +/-   ##
================================================
  Coverage               ?   56.8880%           
================================================
  Files                  ?       1770           
  Lines                  ?     627522           
  Branches               ?          0           
================================================
  Hits                   ?     356985           
  Misses                 ?     246426           
  Partials               ?      24111           
Flag Coverage Δ
integration 37.0007% <40.0778%> (?)
unit 72.5540% <74.3190%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.3289% <0.0000%> (?)

@mjonss
Copy link
Contributor Author

mjonss commented Nov 26, 2024

/retest

Copy link

tiprow bot commented Nov 26, 2024

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@purelind
Copy link
Contributor

/test all

Copy link

tiprow bot commented Nov 26, 2024

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mjonss mjonss requested review from winoros and tangenta November 26, 2024 23:19
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 27, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 27, 2024
Copy link

ti-chi-bot bot commented Nov 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-27 01:35:54.128699513 +0000 UTC m=+600341.748354029: ☑️ agreed by Defined2014.
  • 2024-11-27 01:57:42.556727526 +0000 UTC m=+601650.176382040: ☑️ agreed by tangenta.

Copy link

ti-chi-bot bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tangenta, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit f07d030 into pingcap:release-8.5 Nov 29, 2024
19 checks passed
@mjonss mjonss deleted the truncate-partition-fix-57721 branch November 29, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants