Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, stats: skip (auto) analyze on vector column and index (#56584) #56784

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56584

What problem does this PR solve?

Issue Number: close #56583

Problem Summary:

What changed and how does it work?

This pull does two things:

  • Auto analyze will not be affected by indexes on vector columns anymore.
  • Vector type column will not collect any stats now.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.4 labels Oct 22, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.4@e7c5e3d). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.4     #56784   +/-   ##
================================================
  Coverage               ?   56.2081%           
================================================
  Files                  ?       1751           
  Lines                  ?     628078           
  Branches               ?          0           
================================================
  Hits                   ?     353031           
  Misses                 ?     251132           
  Partials               ?      23915           
Flag Coverage Δ
integration 36.7903% <4.5454%> (?)
unit 72.5013% <50.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.3870% <0.0000%> (?)

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 22, 2024
Copy link

ti-chi-bot bot commented Oct 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-22 13:20:42.149579767 +0000 UTC m=+357242.846370376: ☑️ agreed by hawkingrei.
  • 2024-10-22 13:37:39.936411098 +0000 UTC m=+358260.633201704: ☑️ agreed by zimulala.

@ti-chi-bot ti-chi-bot bot merged commit 8af68d6 into pingcap:release-8.4 Oct 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants