-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: Use/force to apply prefer range scan #56928
Conversation
Hi @terry1purcell. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56928 +/- ##
================================================
+ Coverage 73.1839% 74.8237% +1.6398%
================================================
Files 1671 1720 +49
Lines 460731 476167 +15436
================================================
+ Hits 337181 356286 +19105
+ Misses 102827 97606 -5221
- Partials 20723 22275 +1552
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@qw4990: Your lgtm message is repeated, so it is ignored. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #55632
Problem Summary:
What changed and how does it work?
MySQL will increase the cost of a table scan if FORCE INDEX is used in the query. TiDB does not differentiate between USE and FORCE in the query. This enhancement will add a cost penalty to a full table scan if USE or FORCE is used in the query. It will also apply to ANY full table scan in the query, and not only to the table that the USE/FORCE is applied to. This is in response to customer issues where USE/FORCE is specified, but they still see table scans chosen within their query.
If a USE/FORCE is specified against the PRIMARY index, and there are no other predicates (such that the scan is a full table scan of that primary) - this enhancement will increase that table scan cost.
The cost penalty does not apply to a table range scan.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.