Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: Use/force to apply prefer range scan (#56928) #58444

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56928

What problem does this PR solve?

Issue Number: close #55632

Problem Summary:

What changed and how does it work?

MySQL will increase the cost of a table scan if FORCE INDEX is used in the query. TiDB does not differentiate between USE and FORCE in the query. This enhancement will add a cost penalty to a full table scan if USE or FORCE is used in the query. It will also apply to ANY full table scan in the query, and not only to the table that the USE/FORCE is applied to. This is in response to customer issues where USE/FORCE is specified, but they still see table scans chosen within their query.

If a USE/FORCE is specified against the PRIMARY index, and there are no other predicates (such that the scan is a full table scan of that primary) - this enhancement will increase that table scan cost.

The cost penalty does not apply to a table range scan.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added affects-8.5 This bug affects the 8.5.x(LTS) versions. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.5@71bc625). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #58444   +/-   ##
================================================
  Coverage               ?   57.1901%           
================================================
  Files                  ?       1768           
  Lines                  ?     622786           
  Branches               ?          0           
================================================
  Hits                   ?     356172           
  Misses                 ?     242469           
  Partials               ?      24145           
Flag Coverage Δ
integration 36.7179% <100.0000%> (?)
unit 72.5688% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8711% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.1617% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 20, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 21, 2024
Copy link

ti-chi-bot bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 23, 2024
Copy link

ti-chi-bot bot commented Dec 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-21 01:40:28.03875356 +0000 UTC m=+1266618.127556103: ☑️ agreed by AilinKid.
  • 2024-12-23 03:13:20.104127477 +0000 UTC m=+1444990.192930019: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 13852cc into pingcap:release-8.5 Dec 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants