-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: dynamically adjusting the concurrency and batch size of reorganization job #57468
ddl: dynamically adjusting the concurrency and batch size of reorganization job #57468
Conversation
Hi @fzzf678. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57468 +/- ##
================================================
+ Coverage 72.7875% 74.8176% +2.0300%
================================================
Files 1676 1721 +45
Lines 463667 472204 +8537
================================================
+ Hits 337492 353292 +15800
+ Misses 105328 96775 -8553
- Partials 20847 22137 +1290
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: tangenta <tangenta@126.com>
Co-authored-by: tangenta <tangenta@126.com>
// These two variables are used to control the concurrency and batch size of the reorganization process. | ||
// They can be adjusted dynamically through `admin alter ddl jobs` command. | ||
// Note: Don't get or set these two variables directly, use the functions instead. | ||
Concurrency int64 `json:"concurrency"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make these two fields private?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course these fields should be private, maybe later we can refactor this part and turn it private.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CbcWestwolf, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #57229 #57526
Problem Summary:
What changed and how does it work?
Dynamically adjust the worker count and batch size for the reorganization DDL job. A background goroutine checks and updates the worker count every 2 seconds. The batch size is evaluated and adjusted as needed before processing each chunk of data.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.