Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: dynamically adjusting the concurrency and batch size of reorganization job (#57468) #57607

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57468

What problem does this PR solve?

Issue Number: ref #57229 #57526

Problem Summary:

What changed and how does it work?

Dynamically adjust the worker count and batch size for the reorganization DDL job. A background goroutine checks and updates the worker count every 2 seconds. The batch size is evaluated and adjusted as needed before processing each chunk of data.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 21, 2024
@fzzf678
Copy link
Contributor

fzzf678 commented Nov 21, 2024

/cherry-pick-invite

@ti-chi-bot
Copy link
Member Author

@fzzf678 you're already a collaborator in repo ti-chi-bot/tidb

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 72.99270% with 37 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@99a2df5). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #57607   +/-   ##
================================================
  Coverage               ?   56.8238%           
================================================
  Files                  ?       1770           
  Lines                  ?     626446           
  Branches               ?          0           
================================================
  Hits                   ?     355971           
  Misses                 ?     246414           
  Partials               ?      24061           
Flag Coverage Δ
integration 36.8179% <66.4233%> (?)
unit 72.4847% <62.0438%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.2746% <0.0000%> (?)
---- 🚨 Try these New Features:

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 21, 2024
@fzzf678
Copy link
Contributor

fzzf678 commented Nov 21, 2024

/retest

@fzzf678 fzzf678 requested a review from tangenta November 21, 2024 14:58
@fzzf678
Copy link
Contributor

fzzf678 commented Nov 21, 2024

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 21, 2024
Copy link

ti-chi-bot bot commented Nov 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-21 14:43:35.018633094 +0000 UTC m=+129202.638287613: ☑️ agreed by CbcWestwolf.
  • 2024-11-21 15:03:16.852346204 +0000 UTC m=+130384.472000716: ☑️ agreed by fzzf678.

@fzzf678
Copy link
Contributor

fzzf678 commented Nov 21, 2024

/approve_pr

@fzzf678
Copy link
Contributor

fzzf678 commented Nov 21, 2024

/approve

Copy link

ti-chi-bot bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, fzzf678, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 21, 2024
@ti-chi-bot ti-chi-bot bot merged commit 51e8310 into pingcap:release-8.5 Nov 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants