Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionctx: fix null max value to leading wrong warning #57898

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Dec 2, 2024

What problem does this PR solve?

Issue Number: close #57889

Problem Summary:

What changed and how does it work?

forget to set max value, it will judge wrongly when to verify value.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix null max value to leading wrong warning with tidb_gogc_tuner_max_value。tidb_gogc_tuner_min_value

修复 tidb_gogc_tuner_max_value/tidb_gogc_tuner_min_value 因为 空的 max value 导致错误的warning信息

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/check-issue-triage-complete

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4634%. Comparing base (6434ca4) to head (6db1bcd).
Report is 16 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57898        +/-   ##
================================================
+ Coverage   72.8734%   73.4634%   +0.5899%     
================================================
  Files          1677       1679         +2     
  Lines        464634     465719      +1085     
================================================
+ Hits         338595     342133      +3538     
+ Misses       105152     102819      -2333     
+ Partials      20887      20767       -120     
Flag Coverage Δ
integration 43.3882% <100.0000%> (?)
unit 72.3889% <100.0000%> (+0.1138%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.1492% <ø> (-0.5676%) ⬇️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 2, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 3, 2024
Copy link

ti-chi-bot bot commented Dec 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-02 18:25:03.451271778 +0000 UTC m=+1092891.070926291: ☑️ agreed by winoros.
  • 2024-12-03 02:09:09.972902598 +0000 UTC m=+1120737.592557114: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 3, 2024
Copy link

ti-chi-bot bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: winoros, xhebox, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 3, 2024
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit e0019df into pingcap:master Dec 3, 2024
24 checks passed
@hawkingrei
Copy link
Member Author

/cherrypick release-7.5
/cherrypick release-8.1
/cherrypick release-8.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #57933.

In response to this:

/cherrypick release-7.5
/cherrypick release-8.1
/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #57934.

In response to this:

/cherrypick release-7.5
/cherrypick release-8.1
/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.5: #57935.

In response to this:

/cherrypick release-7.5
/cherrypick release-8.1
/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return wrong warning when to set tidb_gogc_tuner_max_value/tidb_gogc_tuner_min_value
5 participants