-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sessionctx: fix null max value to leading wrong warning (#57898) #57933
sessionctx: fix null max value to leading wrong warning (#57898) #57933
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #57933 +/- ##
================================================
Coverage ? 72.5705%
================================================
Files ? 1415
Lines ? 415302
Branches ? 0
================================================
Hits ? 301387
Misses ? 94094
Partials ? 19821
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #57898
What problem does this PR solve?
Issue Number: close #57889
Problem Summary:
What changed and how does it work?
forget to set max value, it will judge wrongly when to verify value.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.