-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: correct the vector index tests #58039
planner: correct the vector index tests #58039
Conversation
Signed-off-by: Rustin170506 <tech@rustin.me>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #58039 +/- ##
================================================
+ Coverage 73.1711% 73.9378% +0.7667%
================================================
Files 1674 1675 +1
Lines 461507 465668 +4161
================================================
+ Hits 337690 344305 +6615
+ Misses 103079 100644 -2435
+ Partials 20738 20719 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 Self-check (PR reviewed by myself and ready for feedback.)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: time-and-fate, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #57871
Problem Summary:
What changed and how does it work?
Split from #57872
We need to handle the DDL events here to ensure that the stats are loaded into memory. Otherwise, the stats cache entry will be deleted due to this issue: #57901.
Moreover, there are no indexes or predicate columns on this table, so analyzing this table doesn't provide any help.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.