Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: correct the vector index tests #58039

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Dec 6, 2024

What problem does this PR solve?

Issue Number: ref #57871

Problem Summary:

What changed and how does it work?

Split from #57872

We need to handle the DDL events here to ensure that the stats are loaded into memory. Otherwise, the stats cache entry will be deleted due to this issue: #57901.

Moreover, there are no indexes or predicate columns on this table, so analyzing this table doesn't provide any help.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Rustin170506 <tech@rustin.me>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 6, 2024
@Rustin170506 Rustin170506 requested a review from winoros December 6, 2024 03:52
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.9378%. Comparing base (bb9096c) to head (507f3d5).
Report is 116 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58039        +/-   ##
================================================
+ Coverage   73.1711%   73.9378%   +0.7667%     
================================================
  Files          1674       1675         +1     
  Lines        461507     465668      +4161     
================================================
+ Hits         337690     344305      +6615     
+ Misses       103079     100644      -2435     
+ Partials      20738      20719        -19     
Flag Coverage Δ
integration 43.5496% <ø> (?)
unit 72.4749% <ø> (+0.1778%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 46.0404% <ø> (+0.0571%) ⬆️

@Rustin170506 Rustin170506 changed the title test: stabilize vector index tests with updated statistics handling statistics: stabilize vector index tests with updated statistics handling Dec 6, 2024
@Rustin170506 Rustin170506 changed the title statistics: stabilize vector index tests with updated statistics handling planner: stabilize vector index tests with updated statistics handling Dec 6, 2024
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

@Rustin170506 Rustin170506 changed the title planner: stabilize vector index tests with updated statistics handling planner: correct the vector index tests Dec 9, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 9, 2024
Copy link

ti-chi-bot bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: time-and-fate, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 9, 2024
Copy link

ti-chi-bot bot commented Dec 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-09 10:29:39.21727899 +0000 UTC m=+261569.306081533: ☑️ agreed by time-and-fate.
  • 2024-12-09 16:23:02.484137115 +0000 UTC m=+282772.572939655: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit d6b313f into pingcap:master Dec 9, 2024
24 checks passed
Rustin170506 added a commit to ti-chi-bot/tidb that referenced this pull request Dec 20, 2024
Rustin170506 added a commit to ti-chi-bot/tidb that referenced this pull request Dec 20, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 23, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #58458.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants