Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: use DDL subscriber updating stats meta #57872

Merged
merged 12 commits into from
Dec 13, 2024

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Dec 2, 2024

What problem does this PR solve?

Issue Number: close #57871

Problem Summary:

What changed and how does it work?

In this PR, we began using the DDL notifier to handle all DDL events and update the stats meta accordingly.

To maintain the old behavior, we do not register it when the stats lease is less than 1. This means that we won't handle the DDL event for unit tests at all unless you explicitly handle it manually.

In the future, we might want to handle this in unit tests by default. However, doing so could disrupt many existing test cases. For now, I prefer to maintain the old behavior. I plan to migrate to the new approach eventually, but I currently don't have enough time to update all the tests that would break.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9875%. Comparing base (d3add7c) to head (edcf843).
Report is 59 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57872        +/-   ##
================================================
+ Coverage   73.2043%   74.9875%   +1.7832%     
================================================
  Files          1675       1723        +48     
  Lines        461929     472357     +10428     
================================================
+ Hits         338152     354209     +16057     
+ Misses       103014      95867      -7147     
- Partials      20763      22281      +1518     
Flag Coverage Δ
integration 49.0646% <75.0000%> (?)
unit 72.3584% <86.9565%> (+0.0185%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.5333% <ø> (+15.5575%) ⬆️

@Rustin170506 Rustin170506 force-pushed the rustin-patch-ddl-stats-meta branch from 1c856d8 to 294d543 Compare December 4, 2024 06:14
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 4, 2024
@Rustin170506
Copy link
Member Author

/retest

4 similar comments
@Rustin170506
Copy link
Member Author

/retest

@Rustin170506
Copy link
Member Author

/retest

@Rustin170506
Copy link
Member Author

/retest

@Rustin170506
Copy link
Member Author

/retest

@Rustin170506 Rustin170506 force-pushed the rustin-patch-ddl-stats-meta branch 3 times, most recently from 7660538 to 255db8b Compare December 5, 2024 05:43
@Rustin170506
Copy link
Member Author

/retest

@Rustin170506
Copy link
Member Author

/retest

2 similar comments
@Rustin170506
Copy link
Member Author

/retest

@Rustin170506
Copy link
Member Author

/retest

@Rustin170506 Rustin170506 force-pushed the rustin-patch-ddl-stats-meta branch 2 times, most recently from 7b9d3ab to 371de73 Compare December 10, 2024 06:17
@Rustin170506 Rustin170506 force-pushed the rustin-patch-ddl-stats-meta branch 2 times, most recently from 39eebe4 to 989cab4 Compare December 11, 2024 06:26
Signed-off-by: Rustin170506 <tech@rustin.me>
Copy link

tiprow bot commented Dec 12, 2024

@Rustin170506: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test fast_test_tiprow_ddlargsv1
  • /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

  • tidb_parser_test

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

33 / 57 files viewed

pkg/ddl/ddl.go Outdated Show resolved Hide resolved
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

free to unhold

pkg/statistics/handle/ddl/ddl.go Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 13, 2024
Copy link

ti-chi-bot bot commented Dec 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-11 11:13:54.865531586 +0000 UTC m=+437024.954334128: ☑️ agreed by winoros.
  • 2024-12-13 06:17:21.336368756 +0000 UTC m=+592031.425171300: ☑️ agreed by lance6716.

Signed-off-by: Rustin170506 <tech@rustin.me>
Signed-off-by: Rustin170506 <tech@rustin.me>
@Rustin170506
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2024
@Rustin170506
Copy link
Member Author

/retest

2 similar comments
@Rustin170506
Copy link
Member Author

/retest

@Rustin170506
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 27b5392 into pingcap:master Dec 13, 2024
27 checks passed
@Rustin170506 Rustin170506 deleted the rustin-patch-ddl-stats-meta branch December 13, 2024 10:44
@Rustin170506 Rustin170506 added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 18, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 18, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #58387.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a DDL subscriber to handle updates to the stats meta
4 participants