-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: use DDL subscriber updating stats meta #57872
*: use DDL subscriber updating stats meta #57872
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #57872 +/- ##
================================================
+ Coverage 73.2043% 74.9875% +1.7832%
================================================
Files 1675 1723 +48
Lines 461929 472357 +10428
================================================
+ Hits 338152 354209 +16057
+ Misses 103014 95867 -7147
- Partials 20763 22281 +1518
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1c856d8
to
294d543
Compare
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
7660538
to
255db8b
Compare
/retest |
86e0414
to
495cf22
Compare
/retest |
2 similar comments
/retest |
/retest |
7b9d3ab
to
371de73
Compare
39eebe4
to
989cab4
Compare
Signed-off-by: Rustin170506 <tech@rustin.me>
@Rustin170506: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
33 / 57 files viewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
free to unhold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Rustin170506 <tech@rustin.me>
Signed-off-by: Rustin170506 <tech@rustin.me>
/unhold |
/retest |
2 similar comments
/retest |
/retest |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
close pingcap#57871 Signed-off-by: Rustin170506 <techregister@pm.me>
What problem does this PR solve?
Issue Number: close #57871
Problem Summary:
What changed and how does it work?
In this PR, we began using the DDL notifier to handle all DDL events and update the stats meta accordingly.
To maintain the old behavior, we do not register it when the stats lease is less than 1. This means that we won't handle the DDL event for unit tests at all unless you explicitly handle it manually.
In the future, we might want to handle this in unit tests by default. However, doing so could disrupt many existing test cases. For now, I prefer to maintain the old behavior. I plan to migrate to the new approach eventually, but I currently don't have enough time to update all the tests that would break.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.