Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: refactor common functions into subscriber #58127

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Issue Number: ref #57871

Problem Summary:

What changed and how does it work?

Split from #57872

This PR simply moved the common functions into subscriber.go because we will drop these files in upcoming PRs. I am doing this now to reduce the changes needed in the next PR.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Rustin170506 <tech@rustin.me>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/planner SIG: Planner labels Dec 10, 2024
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 59.61538% with 84 lines in your changes missing coverage. Please review.

Project coverage is 73.8150%. Comparing base (93295c2) to head (4c1d3d1).
Report is 101 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58127        +/-   ##
================================================
+ Coverage   73.1325%   73.8150%   +0.6825%     
================================================
  Files          1675       1705        +30     
  Lines        461920     469992      +8072     
================================================
+ Hits         337814     346925      +9111     
+ Misses       103353     101592      -1761     
- Partials      20753      21475       +722     
Flag Coverage Δ
integration 45.9044% <0.0000%> (?)
unit 72.2916% <59.6153%> (+0.0312%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.9728% <ø> (+0.0360%) ⬆️

Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 10, 2024
Copy link

ti-chi-bot bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsa0520, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 10, 2024
Copy link

ti-chi-bot bot commented Dec 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-10 07:55:24.529592194 +0000 UTC m=+338714.618394732: ☑️ agreed by elsa0520.
  • 2024-12-10 10:46:04.734167533 +0000 UTC m=+348954.822970061: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 7e5096e into pingcap:master Dec 10, 2024
25 checks passed
@Rustin170506 Rustin170506 deleted the rustin-patch-refactor-sub branch December 10, 2024 13:29
Rustin170506 added a commit to ti-chi-bot/tidb that referenced this pull request Dec 20, 2024
Rustin170506 added a commit to ti-chi-bot/tidb that referenced this pull request Dec 20, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 23, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #58459.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants