-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: refactor common functions into subscriber #58127
statistics: refactor common functions into subscriber #58127
Conversation
Signed-off-by: Rustin170506 <tech@rustin.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 Self-check (PR reviewed by myself and ready for feedback.)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58127 +/- ##
================================================
+ Coverage 73.1325% 73.8150% +0.6825%
================================================
Files 1675 1705 +30
Lines 461920 469992 +8072
================================================
+ Hits 337814 346925 +9111
+ Misses 103353 101592 -1761
- Partials 20753 21475 +722
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsa0520, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #57871
Problem Summary:
What changed and how does it work?
Split from #57872
This PR simply moved the common functions into
subscriber.go
because we will drop these files in upcoming PRs. I am doing this now to reduce the changes needed in the next PR.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.