Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: use DDL subscriber updating stats meta (#57872) #58387

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 18, 2024

This is an automated cherry-pick of

  1. 5a25eea
  2. d6b313f
  3. 7e5096e
  4. 27b5392
  5. 0dcadef
  6. 1bf4bf1

What problem does this PR solve?

Issue Number: close #57871

Problem Summary:

What changed and how does it work?

In this PR, we began using the DDL notifier to handle all DDL events and update the stats meta accordingly.

To maintain the old behavior, we do not register it when the stats lease is less than 1. This means that we won't handle the DDL event for unit tests at all unless you explicitly handle it manually.

In the future, we might want to handle this in unit tests by default. However, doing so could disrupt many existing test cases. For now, I prefer to maintain the old behavior. I plan to migrate to the new approach eventually, but I currently don't have enough time to update all the tests that would break.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 18, 2024
@Rustin170506 Rustin170506 force-pushed the cherry-pick-57872-to-release-8.5 branch from fb2ae8c to 0ed71f9 Compare December 20, 2024 08:18
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 63.67188% with 93 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@71bc625). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #58387   +/-   ##
================================================
  Coverage               ?   57.0385%           
================================================
  Files                  ?       1770           
  Lines                  ?     627656           
  Branches               ?          0           
================================================
  Hits                   ?     358006           
  Misses                 ?     245593           
  Partials               ?      24057           
Flag Coverage Δ
integration 37.1239% <12.8514%> (?)
unit 72.7253% <62.5000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8711% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.2984% <0.0000%> (?)

@Rustin170506 Rustin170506 force-pushed the cherry-pick-57872-to-release-8.5 branch from 0ed71f9 to 1a1b1a9 Compare December 20, 2024 15:32
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 20, 2024
Copy link

ti-chi-bot bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, Rustin170506

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 23, 2024
Copy link

ti-chi-bot bot commented Dec 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-20 15:35:32.513260244 +0000 UTC m=+1230322.602062787: ☑️ agreed by Rustin170506.
  • 2024-12-23 04:18:40.732858677 +0000 UTC m=+1448910.821661205: ☑️ agreed by lance6716.

@Rustin170506
Copy link
Member

/test all

Copy link

tiprow bot commented Dec 23, 2024

@Rustin170506: No presubmit jobs available for pingcap/tidb@release-8.5

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Rustin170506
Copy link
Member

/retest

@Rustin170506
Copy link
Member

/test all

Copy link

tiprow bot commented Dec 23, 2024

@Rustin170506: No presubmit jobs available for pingcap/tidb@release-8.5

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit ce76011 into pingcap:release-8.5 Dec 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants