-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: use DDL subscriber updating stats meta (#57872) #58387
*: use DDL subscriber updating stats meta (#57872) #58387
Conversation
fb2ae8c
to
0ed71f9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #58387 +/- ##
================================================
Coverage ? 57.0385%
================================================
Files ? 1770
Lines ? 627656
Branches ? 0
================================================
Hits ? 358006
Misses ? 245593
Partials ? 24057
Flags with carried forward coverage won't be shown. Click here to find out more.
|
close pingcap#57871 Signed-off-by: Rustin170506 <techregister@pm.me>
0ed71f9
to
1a1b1a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, Rustin170506 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/test all |
@Rustin170506: No presubmit jobs available for pingcap/tidb@release-8.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
/test all |
@Rustin170506: No presubmit jobs available for pingcap/tidb@release-8.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of
What problem does this PR solve?
Issue Number: close #57871
Problem Summary:
What changed and how does it work?
In this PR, we began using the DDL notifier to handle all DDL events and update the stats meta accordingly.
To maintain the old behavior, we do not register it when the stats lease is less than 1. This means that we won't handle the DDL event for unit tests at all unless you explicitly handle it manually.
In the future, we might want to handle this in unit tests by default. However, doing so could disrupt many existing test cases. For now, I prefer to maintain the old behavior. I plan to migrate to the new approach eventually, but I currently don't have enough time to update all the tests that would break.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.