ttl: fix the issue that one task losing heartbeat will block other tasks (#57919) #58710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
release-note-none
5 tasks
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
size/XL
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
ti-chi-bot
bot
added
size/L
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #58710 +/- ##
================================================
Coverage ? 56.8880%
================================================
Files ? 1770
Lines ? 627105
Branches ? 0
================================================
Hits ? 356748
Misses ? 246227
Partials ? 24130
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lcwangchao
approved these changes
Jan 6, 2025
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
|
This PR depends on #57899. |
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
…57919-to-release-8.5 Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
|
/hold. #57899 is still not merged |
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
…57919-to-release-8.5 Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #57919
What problem does this PR solve?
Issue Number: close #57915
Problem Summary:
If one task failed to update heartbeat, the other tasks will not be tried. It's not expected.
What changed and how does it work?
Print an error and continue to try other tasks.
This PR also adapts the same change for job.
Check List
Tests
Release note