executor: Improve the aesthetics of code review #6137
Conversation
update from origin
executor: Improve the aesthetics of code review pingcap#6130
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
|
|
fix ` nested
delete escape char
executor/grant_test.go
Outdated
| tk.MustExec("CREATE USER 'dduser'@'%' IDENTIFIED by '123456';") | ||
| tk.MustExec("GRANT ALL PRIVILEGES ON `dddb_%`.* TO 'dduser'@'%';") | ||
| tk.MustExec("GRANT ALL PRIVILEGES ON `dddb_%`.`te%` to 'dduser'@'%';") | ||
| tk.MustExec("CREATE USER 'dduser'@`%` IDENTIFIED by '123456';") |
There was a problem hiding this comment.
You modified it wrong. You should modify the quotation marks for the SQL statement instead of the quotation marks for %.
There was a problem hiding this comment.
@winkyao @yangwenmai I don't understand why changing the backquote to single quotes would report the following error. So keep the original backquote.
FAIL: grant_test.go:177: testSuite.TestIssue2456
grant_test.go:180:
tk.MustExec(`GRANT ALL PRIVILEGES ON 'dddb_%'.* TO 'dduser'@'%';`)
/Users/marong/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:160:
tk.c.Assert(err, check.IsNil, check.Commentf("sql:%s, %v, error stack %v", sql, args, errors.ErrorStack(err)))
... value *errors.Err = &errors.Err{message:"", cause:(*errors.errorString)(0xc4201c2d40), previous:(*errors.Err)(0xc4205d2730), file:"/Users/marong/go/src/github.com/pingcap/tidb/util/testkit/testkit.go", line:134} ("line 1 column 32 near \".* TO 'dduser'@'%';\" (total length 51)")
... sql:GRANT ALL PRIVILEGES ON 'dddb_%'.* TO 'dduser'@'%';, [], error stack line 1 column 32 near ".* TO 'dduser'@'%';" (total length 51)
There was a problem hiding this comment.
Just keep the original code is ok:
tk.MustExec("CREATE USER 'dduser'@'%' IDENTIFIED by '123456';")
tk.MustExec("GRANT ALL PRIVILEGES ON `dddb_%`.* TO 'dduser'@'%';")
tk.MustExec("GRANT ALL PRIVILEGES ON `dddb_%`.`te%` to 'dduser'@'%';")
There was a problem hiding this comment.
@winkyao executor/grant_test.go have been changed to original, thx.
|
PTAL @yangwenmai |
|
LGTM |
|
/run-all-tests |
|
/run-unit-test |
Improve the aesthetics of code review in executor/grant_test.go.