store/mockstore: Add raw delete range to mock store #6156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coocood PTAL |
|
@MyonKeminta |
|
@coocood Where to put the test? |
|
@MyonKeminta |
|
@tiancaiamao @coocood PTAL |
|
|
tiancaiamao
reviewed
Apr 4, 2018
| // testMVCCLevelDB is used to test MVCCLevelDB implementation. | ||
| type testMVCCLevelDB struct { | ||
| testMockTiKVSuite | ||
| } |
There was a problem hiding this comment.
Friendly remind: avoid to move code if it's not necessary.
Because it would make the code reviewer's work easier.
|
LGTM |
|
/run-all-tests |
|
/run-integration-common-test |
|
.....It seems that changes in this pr was merged with #6157 .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's required to test raw delete range API, which will be added to ticlient