store/tikv: Add raw delete range API #6157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…delete-range-interface
tiancaiamao
reviewed
Mar 30, 2018
store/tikv/rawkv.go
Outdated
| func (c *RawKVClient) DeleteRange(startKey []byte, endKey []byte) error { | ||
| start := time.Now() | ||
| defer func() { | ||
| metrics.TiKVRawkvCmdHistogram.WithLabelValues("delete_range").Observe(time.Since(start).Seconds()) |
There was a problem hiding this comment.
Add succ or error label?
| @@ -14,6 +14,7 @@ | |||
| package tikv | |||
|
|
|||
| import ( | |||
| "bytes" | |||
There was a problem hiding this comment.
Add a newline after this
store/tikv/rawkv_test.go
Outdated
| s.mustPut(c, []byte("k1"), []byte("v1")) | ||
| s.mustPut(c, []byte("k3"), []byte("v3")) | ||
|
|
||
| newRegionID, peerID := s.cluster.AllocID(), s.cluster.AllocID() | ||
| s.cluster.SplitRaw(loc.Region.id, newRegionID, []byte("k2"), []uint64{peerID}, peerID) | ||
| s.split(c, "k", "k2") |
There was a problem hiding this comment.
Let split return error and c.Assert(s.split(c, "k", "k2"), IsNil) here,
or rename split to mustSplit
I prefer former, because when there are many split() call and assert failed, we won't lost the error stack.
added 12 commits
April 2, 2018 11:36
…delete-range-interface
…delete-range-interface
|
LGTM @coocood |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add raw delete range API to ticlient.
Please check PR #6156 first.