ddl, metrics: remove DDL version in metrics #7737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazycs520
reviewed
Sep 18, 2018
ddl/syncer.go
Outdated
| @@ -325,8 +324,7 @@ func (s *schemaVersionSyncer) OwnerCheckAllVersions(ctx context.Context, latestV | |||
|
|
|||
| var err error | |||
| defer func() { | |||
| ver := strconv.FormatInt(latestVer, 10) | |||
| metrics.OwnerHandleSyncerHistogram.WithLabelValues(metrics.OwnerGetGlobalVersion, ver, metrics.RetLabel(err)).Observe(time.Since(startTime).Seconds()) | |||
| metrics.OwnerHandleSyncerHistogram.WithLabelValues(metrics.OwnerGetGlobalVersion, metrics.RetLabel(err)).Observe(time.Since(startTime).Seconds()) | |||
There was a problem hiding this comment.
s/OwnerGetGlobalVersion/OwnerCheckAllVersions ?
|
PTAL @crazycs520 @ciscoxll @winkyao |
|
/run-all-tests |
|
LGTM |
shenli
added
status/LGT2
shenli
approved these changes
Sep 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related #7472
When the updating schema is frequent, the DDL version will be very much. But we'd better not overuse labels in prometheus. Refer to https://prometheus.io/docs/practices/instrumentation/#do-not-overuse-labels
What is changed and how it works?
Remove the label of the version in metrics.
Check List
Tests