ddl, metrics: add job action and schema version information to metrics #7472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimulala
added
component/DDL-need-LGT3
component/metrics
and removed
component/DDL-need-LGT3
labels
|
/run-all-tests |
|
/run-unit-test |
ciscoxll
reviewed
Aug 24, 2018
|
|
||
| // Metrics for ddl_worker.go. | ||
| WorkerAddDDLJob = "add_job" | ||
| WorkerRunDDLJob = "run_job" |
There was a problem hiding this comment.
I also feel the label is not enough, so I also add a label.
|
PTAL @winkyao @shenli @crazycs520 |
crazycs520
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add job action and schema version information to metrics.
Remove "DDLJobErrCounter"(We didn't use it before in grafana) and add error count information to "DDLWorkerHistogram".
What is changed and how it works?
Add two labels.
Check List
Tests
Related changes
tidb-ansiblerepositorypingcap/tidb-ansiable#508