expression: refine built-in func truncate to support uint arg #8000

yu34po · 2018-10-23T03:54:20Z

What problem does this PR solve?

What is changed and how it works?

1.add an builtinTruncateUintSig Function to support unsigned int truncate
2.change builtinTruncateIntSig truncate function to avoid get incorrect value

Check List

Tests

Unit test
Integration test

Code changes

Has exported function/method change

Side effects
None

Related changes

Need to cherry-pick to the release branch
release-2.0 release-2.1

…nt number use float64 transate maybe get approximate value

sre-bot · 2018-10-23T03:54:23Z

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

CLAassistant · 2018-10-23T03:54:28Z

All committers have signed the CLA.

zz-jason · 2018-10-23T04:56:56Z

expression/builtin_math.go

+ return newSig
+}
+
+type builtinTruncateUnintSig struct {


s/Unint/Uint/

zz-jason · 2018-10-23T04:58:06Z

@yu34po please check the Check List carefully, remove the unnecessary items.

… truncate_number

expression/builtin_math_test.go

XuHuaiyu

LGMT

winoros

lgtm

zz-jason · 2018-10-24T07:25:28Z

/run-all-tests

zz-jason · 2018-10-24T07:43:16Z

@yu34po would you please help us to cherrypick this commit to the release-2.1 and release-2.0 branches?

yu34po · 2018-10-25T09:01:32Z

@zz-jason cannot do it as my local commit has been deleted..

zz-jason · 2018-10-25T09:03:40Z

@yu34po You can find the commit in the tidb master branch and use git cherry-pick $commit_hash to cherry pick that commit to the release-2.1 branch.

bugfix fixed pingcap#7518 expression: MySQL compatible current_user function (pingcap#7801) plan: propagate constant over outer join (pingcap#7794) - extract `outerCol = const` from join conditions and filter conditions, substitute `outerCol` in join conditions with `const`; - extract `outerCol = innerCol` from join conditions, derive new join conditions based on this column equal condition and `outerCol` related expressions in join conditions and filter conditions; util/timeutil: fix data race caused by forgetting set stats lease to 0 (pingcap#7901) stats: handle ddl event for partition table (pingcap#7903) plan: implement Operand and Pattern of cascades planner. (pingcap#7910) planner: not convert to TableDual if empty range is derived from deferred constants (pingcap#7808) plan: move projEliminate behind aggEliminate (pingcap#7909) admin: fix admin check table bug of byte compare (pingcap#7887) * admin: remove reflect deepEqual stats: fix panic caused by empty histogram (pingcap#7912) plan: fix panic caused by empty schema of LogicalTableDual (pingcap#7906) * fix drop view if exist error (pingcap#7833) executor: refine `explain analyze` (pingcap#7888) executor: add an variable to compatible with MySQL insert for OGG (pingcap#7863) expression: maintain `DeferredExpr` in aggressive constant folding. (pingcap#7915) stats: fix histogram boundaries overflow error (pingcap#7883) ddl:support the definition of `null` change to `not null` using `alter table` (pingcap#7771) * ddl:support the definition of null change to not null using alter table ddl: add check when create table with foreign key. (pingcap#7885) * ddl: add check when create table with foreign key planner: eliminate if null on non null column (pingcap#7924) executor: fix a bug in point get (pingcap#7934) planner, executor: refine ColumnPrune for LogicalUnionAll (pingcap#7930) executor: fix panic when limit is too large (pingcap#7936) ddl: add TiDB version to metrics (pingcap#7902) stats: limit the length of sample values (pingcap#7931) vendor: update tipb (pingcap#7893) planner: support the Group and GroupExpr for the cascades planner (pingcap#7917) store/tikv: log more information when other err occurs (pingcap#7948) types: fix date time parse (pingcap#7933) ddl: just print error message when ddl job is normal to calcel, to eliminate noisy log (pingcap#7875) stats: update delta info for partition table (pingcap#7947) explaintest: add explain test for partition pruning (pingcap#7505) util: move disjoint set to util package (pingcap#7950) util: add PreAlloc4Row and Insert for Chunk and List (pingcap#7916) executor: add the slow log for commit (pingcap#7951) expression: add builtin json_keys (pingcap#7776) privilege: add USAGE in `show grants` for mysql compatibility (pingcap#7955) ddl: fix invailid ddl job panic (pingcap#7940) *: move ast.NewValueExpr to standalone parser_driver package (pingcap#7952) Make the ast package get rid of the dependency of types.Datum server: allow cors http request (pingcap#7939) *: move `Statement` and `RecordSet` from ast to sqlexec package (pingcap#7970) pr suggestion update executor/aggfuncs: split unit tests to corresponding file (pingcap#7993) store/tikv: fix typo (pingcap#7990) executor, planner: clone proj schema for different children in buildProj4Union (pingcap#7999) executor: let information_schema be the first database in ShowDatabases (pingcap#7938) stats: use local feedback for partition table (pingcap#7963) executor: add unit test for aggfuncs (pingcap#7966) server: add log for binary execute statement (pingcap#7987) admin: refine admin check decoder (pingcap#7862) executor: improve wide table insert & update performance (pingcap#7935) ddl: fix reassigned partition id in `truncate table` does not take effect (pingcap#7919) fix reassigned partition id in truncate table does not take effect add changelog for 2.1.0 rc4 (pingcap#8020) *: make parser package dependency as small as possible (pingcap#7989) parser: support `:=` in the `set` syntax (pingcap#8018) According to MySQL document, `set` use the = assignment operator, but the := assignment operator is also permitted stats: garbage collect stats for partition table (pingcap#7962) docs: add the proposal for the column pool (pingcap#7988) expression: refine built-in func truncate to support uint arg (pingcap#8000) stats: support show stats for partition table (pingcap#8023) stats: update error rate for partition table (pingcap#8022) stats: fix estimation for out of range point queries (pingcap#8015) *: move parser to a separate repository (pingcap#8036) executor: fix wrong result when index join on union scan. (pingcap#8031) Do not modify Plan of dataReaderBuilder directly, because it would impact next batch of outer rows, as well as other concurrent inner workers. Instead, build a local child builder to store the child plan. planner: fix a panic of a cached prepared statement with IndexScan (pingcap#8017) *: fix the issue of executing DDL after executing SQL failure in txn (pingcap#8044) * ddl, executor: fix the issue of executing DDL after executing SQL failure in txn add unit test remove debug info add like evaluator case sensitive test ddl, domain: make schema correct after canceling jobs (pingcap#7997) unit test fix code format proposal: maintaining histograms in plan. (pingcap#7605) support _tidb_rowid for table scan range (pingcap#8047) var rename fix

…p#8000)

…#8068)

…#8069)

builtin truncate function supprot unsignedint type and fix truncate i…

1618418

…nt number use float64 transate maybe get approximate value

Merge branch 'master' into truncate_number

13d68fe

XuHuaiyu added type/enhancement The issue or PR belongs to an enhancement. contribution This PR is from a community contributor. component/expression labels Oct 23, 2018

zz-jason reviewed Oct 23, 2018

View reviewed changes

expression/builtin_math.go Outdated

return newSig

}

type builtinTruncateUnintSig struct {

Copy link

Member

zz-jason Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Unint/Uint/

yu34po added 4 commits October 23, 2018 13:26

file fmt and replace unint to uint

814ab32

Merge branch 'truncate_number' of https://github.com/yu34po/tidb into…

952bd81

… truncate_number

Merge branch 'master' into truncate_number

5cb8ec1

del else block for lint check

df225dd

ngaut changed the title ~~builtin truncate function supprot unsignedint type and fix truncate i…~~ builtin truncate function support unsignedint type and fix truncate i… Oct 23, 2018

ngaut changed the title ~~builtin truncate function support unsignedint type and fix truncate i…~~ builtin truncate function support unsigned int type and fix truncate i… Oct 23, 2018

XuHuaiyu reviewed Oct 23, 2018

View reviewed changes

expression/builtin_math_test.go Show resolved Hide resolved

aaa integration test for truncate

e3a04a7

XuHuaiyu changed the title ~~builtin truncate function support unsigned int type and fix truncate i…~~ expression: refine built-in func truncate to support uint arg Oct 23, 2018

XuHuaiyu reviewed Oct 23, 2018

View reviewed changes

winoros approved these changes Oct 24, 2018

View reviewed changes

zz-jason added 2 commits October 24, 2018 15:17

Merge branch 'master' into truncate_number

032600b

Merge branch 'master' into truncate_number

6284569

zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 24, 2018

zz-jason merged commit b87b5f0 into pingcap:master Oct 24, 2018

zz-jason added the status/all tests passed label Oct 24, 2018

yu34po added a commit to yu34po/tidb that referenced this pull request Oct 26, 2018

expression: refine built-in func truncate to support uint arg (pingca…

88ee1f9

…p#8000)

yu34po added a commit to yu34po/tidb that referenced this pull request Oct 26, 2018

expression: refine built-in func truncate to support uint arg (pingca…

f974cfd

…p#8000)

zz-jason pushed a commit that referenced this pull request Oct 26, 2018

expression: refine built-in func truncate to support uint arg (#8000) (…

75192d7

…#8068)

zz-jason pushed a commit that referenced this pull request Oct 31, 2018

expression: refine built-in func truncate to support uint arg (#8000) (…

0a37bd5

…#8069)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

expression: refine built-in func truncate to support uint arg #8000

expression: refine built-in func truncate to support uint arg #8000

yu34po commented Oct 23, 2018 •

edited by winoros

Loading

sre-bot commented Oct 23, 2018

CLAassistant commented Oct 23, 2018 •

edited

Loading

zz-jason Oct 23, 2018

zz-jason commented Oct 23, 2018

XuHuaiyu left a comment

winoros left a comment

zz-jason commented Oct 24, 2018

zz-jason commented Oct 24, 2018

yu34po commented Oct 25, 2018

zz-jason commented Oct 25, 2018

expression: refine built-in func truncate to support uint arg #8000

expression: refine built-in func truncate to support uint arg #8000

Conversation

yu34po commented Oct 23, 2018 • edited by winoros Loading

What problem does this PR solve?

What is changed and how it works?

Check List

sre-bot commented Oct 23, 2018

CLAassistant commented Oct 23, 2018 • edited Loading

zz-jason Oct 23, 2018

Choose a reason for hiding this comment

zz-jason commented Oct 23, 2018

XuHuaiyu left a comment

Choose a reason for hiding this comment

winoros left a comment

Choose a reason for hiding this comment

zz-jason commented Oct 24, 2018

zz-jason commented Oct 24, 2018

yu34po commented Oct 25, 2018

zz-jason commented Oct 25, 2018

yu34po commented Oct 23, 2018 •

edited by winoros

Loading

CLAassistant commented Oct 23, 2018 •

edited

Loading