executor, sessionctx: add checks for system variable validate_password_xxxx #8227

alapha23 · 2018-11-07T14:46:15Z

What problem does this PR solve?

Corresponding to Issue #7195, I added correctness check for system variables: validate_password_number_count, validate_password_special_char_count, validate_password_length, validate_password_mixed_case_count, validate_password_policy.

What is changed and how it works?

Executor and sessionctx are modified according to the framework mentioned in #7117

Tests

Unit test

This change is

sre-bot · 2018-11-07T14:46:18Z

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

shenli · 2018-11-07T18:40:36Z

@alapha23 Thanks for your contribution!
Please fix the CI.

shenli · 2018-11-20T02:59:52Z

@alapha23 A friendly ping. Any update?

lysu · 2018-11-21T14:40:31Z

/run-all-tests

go.mod

lysu · 2018-11-22T05:55:57Z

@alapha23 please fix CI caused by new testcase, thanks

set_test.go:529:
    tk.MustExec("set @@global.validate_password_policy=-1")
/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:167:
    tk.c.Assert(err, check.IsNil, check.Commentf("sql:%s, %v, error stack %v", sql, args, errors.ErrorStack(err)))
... value *errors.withStack = [variable:1231]Variable 'validate_password_policy' can't be set to the value of '-1' ("[variable:1231]Variable 'validate_password_policy' can't be set to the value of '-1'")
... sql:set @@global.validate_password_policy=-1, [], error stack [variable:1231]Variable 'validate_password_policy' can't be set to the value of '-1'

https://dev.mysql.com/doc/refman/8.0/en/validate-password-options-variables.html#sysvar_validate_password_policy

… too long

lysu · 2018-11-22T08:37:50Z

/run-all-tests

XuHuaiyu · 2018-11-22T08:39:49Z

sessionctx/variable/sysvar.go

@@ -269,7 +270,6 @@ var defaultSysVars = []*SysVar{
 	{ScopeNone, "performance_schema_max_file_classes", "50"},
 	{ScopeGlobal, "expire_logs_days", "0"},
 	{ScopeGlobal | ScopeSession, "binlog_rows_query_log_events", "OFF"},
-	{ScopeGlobal, "validate_password_policy", "1"},


why do we remove this?

According to mysql reference, This validate_password plugin system variable is deprecated and will be removed in a future version of MySQL.
So I presume we will not need it in the future. What do you think?

@alapha23 I think we can discuss whether to remove these unused variables in another PR. For this PR, let's focused on the validation of validate_password_number_count and validate_password_length.

lysu

LGTM

zz-jason · 2018-11-26T11:02:55Z

@alapha23 pingcap/parser#25 has been merged, could you update go.mod to point to the latest pingcap/parser?

zz-jason · 2018-11-26T11:07:10Z

executor/set_test.go

+	tk.MustQuery("show warnings").Check(testutil.RowsWithSep("|", "Warning|1292|Truncated incorrect validate_password_number_count value: '-1'"))
+
+	tk.MustExec("set @@global.validate_password_length=-1")
+	tk.MustQuery("show warnings").Check(testutil.RowsWithSep("|", "Warning|1292|Truncated incorrect validate_password_length value: '-1'"))


It's better to add some positive test cases. For example: set @@global.validate_password_number_count=8

Thank you. I'll do that

I am quite confused since reference doesn't set an upper bound on validate_password_number_count, are you suggesting that it is an error when validate_password_number_count=8?

No, I mean you can add some following tests:

tk.MustExec("set @@global.validate_password_length=8") tk.MustQuery("show warnings").Check(testutil.Rows())

zz-jason · 2018-11-26T11:28:38Z

executor/set_test.go

+	tk.MustQuery("show warnings").Check(testutil.RowsWithSep("|", "Warning|1292|Truncated incorrect validate_password_number_count value: '-1'"))
+
+	tk.MustExec("set @@global.validate_password_length=-1")
+	tk.MustQuery("show warnings").Check(testutil.RowsWithSep("|", "Warning|1292|Truncated incorrect validate_password_length value: '-1'"))


No, I mean you can add some following tests:

tk.MustExec("set @@global.validate_password_length=8") tk.MustQuery("show warnings").Check(testutil.Rows())

it's a mistake ..

zz-jason · 2018-11-26T13:28:18Z

go.mod

@@ -52,3 +52,5 @@ require (
 	sourcegraph.com/sourcegraph/appdash v0.0.0-20180531100431-4c381bd170b4
 	sourcegraph.com/sourcegraph/appdash-data v0.0.0-20151005221446-73f23eafcf67
 )
+
+replace github.com/pingcap/parser => github.com/alapha23/parser v0.0.0-20181126070418-f5119577d517


pingcap/parser#25 is merged, this line should be removed. We should use the latest github.com/pingcap/parser.

zz-jason

LGTM

shenli added the contribution This PR is from a community contributor. label Nov 7, 2018

alapha23 mentioned this pull request Nov 8, 2018

Fix variable formatting for ErrTruncateWrongValue pingcap/parser#25

Merged

zz-jason added the component/server label Nov 20, 2018

lysu self-requested a review November 21, 2018 14:29

lysu force-pushed the check_sysvar branch from 6094dc8 to 16ae0a1 Compare November 21, 2018 14:39

lysu reviewed Nov 21, 2018

View reviewed changes

go.mod Outdated Show resolved Hide resolved

alapha23 force-pushed the check_sysvar branch from 16ae0a1 to 71e3df1 Compare November 21, 2018 15:12

Add checks for system variable validate_password_xxxx

6d70839

alapha23 force-pushed the check_sysvar branch from c9b47e7 to 6d70839 Compare November 22, 2018 07:07

remove system variable validate_password_mixed_case_count since it is…

54302f2

… too long

alapha23 force-pushed the check_sysvar branch from abd2502 to 54302f2 Compare November 22, 2018 07:21

alapha23 added 3 commits November 22, 2018 02:38

fmt

efa76a7

typo

59dc1d3

Merge branch 'master' into check_sysvar

4562aa8

XuHuaiyu changed the title ~~Add checks for system variable validate_password_xxxx~~ executor, sessionctx: add checks for system variable validate_password_xxxx Nov 22, 2018

XuHuaiyu reviewed Nov 22, 2018

View reviewed changes

Merge branch 'master' into check_sysvar

6b95ff5

lysu reviewed Nov 26, 2018

View reviewed changes

zz-jason reviewed Nov 26, 2018

View reviewed changes

zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 26, 2018

zz-jason previously approved these changes Nov 26, 2018

View reviewed changes

alapha23 force-pushed the check_sysvar branch from 4bb4150 to 2d47a00 Compare November 26, 2018 12:05

zz-jason reviewed Nov 26, 2018

View reviewed changes

add test for validate_password_length

b21ba66

alapha23 force-pushed the check_sysvar branch from d0f85b3 to b21ba66 Compare November 26, 2018 13:33

zz-jason approved these changes Nov 26, 2018

View reviewed changes

Merge branch 'master' into check_sysvar

faa0721

zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 26, 2018

Merge branch 'master' into check_sysvar

5714966

zz-jason merged commit 5035e48 into pingcap:master Nov 26, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

executor, sessionctx: add checks for system variable validate_password_xxxx #8227

executor, sessionctx: add checks for system variable validate_password_xxxx #8227

alapha23 commented Nov 7, 2018 •

edited by c4pt0r

Loading

sre-bot commented Nov 7, 2018

shenli commented Nov 7, 2018

shenli commented Nov 20, 2018

lysu commented Nov 21, 2018

lysu commented Nov 22, 2018

lysu commented Nov 22, 2018

XuHuaiyu Nov 22, 2018

alapha23 Nov 22, 2018 •

edited

Loading

zz-jason Nov 26, 2018

lysu left a comment

zz-jason commented Nov 26, 2018

zz-jason Nov 26, 2018

alapha23 Nov 26, 2018

alapha23 Nov 26, 2018 •

edited

Loading

zz-jason Nov 26, 2018

zz-jason Nov 26, 2018

zz-jason Nov 26, 2018

zz-jason left a comment

executor, sessionctx: add checks for system variable validate_password_xxxx #8227

executor, sessionctx: add checks for system variable validate_password_xxxx #8227

Conversation

alapha23 commented Nov 7, 2018 • edited by c4pt0r Loading

What problem does this PR solve?

What is changed and how it works?

Tests

sre-bot commented Nov 7, 2018

shenli commented Nov 7, 2018

shenli commented Nov 20, 2018

lysu commented Nov 21, 2018

lysu commented Nov 22, 2018

lysu commented Nov 22, 2018

XuHuaiyu Nov 22, 2018

Choose a reason for hiding this comment

alapha23 Nov 22, 2018 • edited Loading

Choose a reason for hiding this comment

zz-jason Nov 26, 2018

Choose a reason for hiding this comment

lysu left a comment

Choose a reason for hiding this comment

zz-jason commented Nov 26, 2018

zz-jason Nov 26, 2018

Choose a reason for hiding this comment

alapha23 Nov 26, 2018

Choose a reason for hiding this comment

alapha23 Nov 26, 2018 • edited Loading

Choose a reason for hiding this comment

zz-jason Nov 26, 2018

Choose a reason for hiding this comment

zz-jason Nov 26, 2018

Choose a reason for hiding this comment

zz-jason Nov 26, 2018

Choose a reason for hiding this comment

zz-jason left a comment

Choose a reason for hiding this comment

alapha23 commented Nov 7, 2018 •

edited by c4pt0r

Loading

alapha23 Nov 22, 2018 •

edited

Loading

alapha23 Nov 26, 2018 •

edited

Loading