-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plan: use Column.UniqueID
in conditionChecker
of ranger
#8236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
added
status/WIP
type/bugfix
This PR fixes a bug.
sig/planner
SIG: Planner
labels
Nov 8, 2018
/run-all-tests |
eurekaka
force-pushed
the
ifnull_tbl_scan
branch
from
November 9, 2018 12:58
feae858
to
26e2f52
Compare
/run-all-tests |
XuHuaiyu
reviewed
Nov 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
winoros
approved these changes
Nov 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
zz-jason
pushed a commit
to zz-jason/tidb
that referenced
this pull request
Mar 7, 2019
XuHuaiyu
pushed a commit
to XuHuaiyu/tidb
that referenced
this pull request
Mar 7, 2019
zz-jason
pushed a commit
that referenced
this pull request
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/planner
SIG: Planner
status/LGT1
Indicates that a PR has LGTM 1.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #8223
What is changed and how it works?
UniqueID
ofColumn
in ranger instead ofColName
, then even if the column name is incorrect, correct index scan can be chosen;Keep correct column name in projection elimination.Both approaches can fix the bug independently, but seems we'd better to have them all.We have to keep the original column name restore logic in
resolveColumnAndReplace
in order to maintain the compatibility with MySQL for this query:if we remove line 54 and 56 from TiDB source code:
we would get result like:
Check List
Tests
Side effects
N/A
Related changes