plan: use Column.UniqueID in conditionChecker of ranger (#8236)
#9587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
added
type/bugfix
|
/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 |
eurekaka
reviewed
Mar 7, 2019
| c.Assert(fmt.Sprintf("%s", conds), Equals, tt.accessConds, Commentf("wrong access conditions for expr: %s", tt.exprStr)) | ||
| result, err := ranger.BuildColumnRange(conds, new(stmtctx.StatementContext), col.RetType) | ||
| c.Assert(err, IsNil) | ||
| got := fmt.Sprintf("%v", result) | ||
| c.Assert(got, Equals, tt.resultStr, Commentf("different for expr %s, col: %v", tt.exprStr, col)) | ||
| } | ||
| } | ||
|
|
||
| func (s *testRangerSuite) TestIndexRangeElimininatedProjection(c *C) { |
There was a problem hiding this comment.
We should remove this test case, since 2.1 does not have optimization to simplify ifnull() expression, so this test would fail.
There was a problem hiding this comment.
How about keeping the test and modifying the test expect result?
|
/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 |
zz-jason
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #8236