ddl: support alter table .. truncate partition #8624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-sqllogic-test tidb-test=pr/681 |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
crazycs520
reviewed
Dec 9, 2018
ddl/partition.go
Outdated
| // TODO: MySQL behavior for hash partition is weird, "create table .. partition by hash partition 4", | ||
| // it use p0, p1, p2, p3 as partition names automatically. | ||
| for _, def := range meta.Partition.Definitions { | ||
| if strings.EqualFold(def.Name.L, strings.ToLower(parName)) { |
There was a problem hiding this comment.
save strings.ToLower(partName) to local variable? ditto in line#399
crazycs520
reviewed
Dec 9, 2018
winkyao
reviewed
Dec 9, 2018
winkyao
reviewed
Dec 9, 2018
ddl/ddl_api.go
Outdated
| TableID: meta.ID, | ||
| Type: model.ActionTruncateTablePartition, | ||
| BinlogInfo: &model.HistoryInfo{}, | ||
| Args: []interface{}{spec.Name}, |
There was a problem hiding this comment.
Why not use partition id to remove. Before this job is handling, maybe the spec.Name partition is removed and added back with different partition id?
|
/run-all-tests |
|
/rebuild |
tiancaiamao
force-pushed
the
truncate-partition
branch
from
947ab7f to
33c5ea3
Compare
|
/run-all-tests |
|
/rebuild |
|
/run-circleci |
|
/run-all-tests |
ciscoxll
reviewed
Dec 10, 2018
ciscoxll
added
status/LGT3
tiancaiamao
force-pushed
the
truncate-partition
branch
from
097c556 to
7c06dbb
Compare
|
/run-all-tests |
|
/run-all-tests |
|
/run-unit-test |
|
/run-common-test |
|
/run-common-test tidb-test=pr/688 |
1 similar comment
|
/run-common-test tidb-test=pr/688 |
winkyao
approved these changes
Dec 11, 2018
12 tasks
iamzhoug37
pushed a commit
to iamzhoug37/tidb
that referenced
this pull request
Dec 13, 2018
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Jan 16, 2019
ngaut
pushed a commit
that referenced
this pull request
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #8435
What is changed and how it works?
Support alter table truncate partition
Check List
Tests
@ciscoxll @winkyao @zimulala
This change is