Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: support alter table .. truncate partition (#8624) #9093

Merged
merged 5 commits into from
Jan 17, 2019

Conversation

tiancaiamao
Copy link
Contributor

Cherry-pick #8624 to release-2.1
Need merge parser first pingcap/parser#181

@crazycs520 @winkyao @jackysp

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 16, 2019
@tiancaiamao
Copy link
Contributor Author

PTAL @zimulala

break
}
}
if !find {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do it in master ?

@tiancaiamao
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1

ddl/partition.go Outdated Show resolved Hide resolved
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 17, 2019
@tiancaiamao
Copy link
Contributor Author

@crazycs520 @winkyao

@zimulala
Copy link
Contributor

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@ngaut ngaut merged commit 422a108 into pingcap:release-2.1 Jan 17, 2019
@tiancaiamao tiancaiamao deleted the truncate-partition branch February 20, 2019 13:11
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants