ddl : fix concurrent add partition problem #8783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zimulala @crazycs520 PTAL |
|
s/parallel/concurrent/ |
ciscoxll
changed the title
zimulala
reviewed
Dec 25, 2018
| @@ -673,6 +684,14 @@ func (s *testStateChangeSuite) testControlParallelExecSQL(c *C, sql1, sql2 strin | |||
| c.Assert(err, IsNil) | |||
| defer s.se.Execute(context.Background(), "drop table t") | |||
|
|
|||
| _, err = s.se.Execute(context.Background(), "drop database if exists t_part") | |||
There was a problem hiding this comment.
I think we can add an argument to distinguish between using a partitioned table or a general table.
There was a problem hiding this comment.
@zimulala master branch has opened the range partition table by default.
crazycs520
reviewed
Dec 25, 2018
|
@tiancaiamao PTAL |
tiancaiamao
reviewed
Dec 28, 2018
|
LGTM |
|
Please cherry-pick this PR to 2.1. |
ciscoxll
added
status/LGT2
|
/run-all-tests |
crazycs520
approved these changes
Dec 29, 2018
ciscoxll
added
status/LGT3
yu34po
pushed a commit
to yu34po/tidb
that referenced
this pull request
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When adding partitions in concurrent, there is a problem if the
values less thanare not checked after the ddl job is enqueued.What is changed and how it works?
checkAddPartitionValueThis function should also be evaluated once inonAddTablePartition.Check List
Tests
This change is