Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl : fix concurrent add partition problem #8902

Merged
merged 5 commits into from
Jan 3, 2019
Merged

ddl : fix concurrent add partition problem #8902

merged 5 commits into from
Jan 3, 2019

Conversation

ciscoxll
Copy link
Contributor

@ciscoxll ciscoxll commented Jan 2, 2019

Cherry pick #8783

This change is Reviewable

@ciscoxll
Copy link
Contributor Author

ciscoxll commented Jan 2, 2019

@winkyao @zimulala @crazycs520 PTAL

zimulala
zimulala reviewed Jan 2, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 2, 2019
@crazycs520
Copy link
Contributor

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

crazycs520
crazycs520 previously approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciscoxll ciscoxll added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 2, 2019
@ciscoxll
Copy link
Contributor Author

ciscoxll commented Jan 2, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 gofail=etcd-io

@zz-jason
Copy link
Member

zz-jason commented Jan 2, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 gofail=etcd-io

@ciscoxll
Copy link
Contributor Author

ciscoxll commented Jan 3, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 gofail=etcd-io

@crazycs520
Copy link
Contributor

/run-unit-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 gofail=etcd-io

@ciscoxll
Copy link
Contributor Author

ciscoxll commented Jan 3, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@ciscoxll
Copy link
Contributor Author

ciscoxll commented Jan 3, 2019

@tiancaiamao PTAL

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jan 3, 2019
@ngaut ngaut merged commit 5a1ec09 into pingcap:release-2.1 Jan 3, 2019
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@crazycs520 crazycs520 crazycs520 left review comments

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/sql-infra SIG: SQL Infra status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ciscoxll @crazycs520 @zz-jason @tiancaiamao @zimulala @ngaut @you06 @sre-bot