*: support variable `log_bin` #9343

aliiohs · 2019-02-18T07:59:42Z

issue：#9201

Support log_bin

i changed some files,like:
sessionctx/variable/sysvar.go:395
sessionctx/variable/sysvar.go:751
sessionctx/variable/varsutil.go:351
executor/set_test.go:223

… test only contains session level

codecov-io · 2019-02-18T08:28:13Z

Codecov Report

Merging #9343 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #9343      +/-   ##
==========================================
- Coverage   67.14%   67.13%   -0.02%     
==========================================
  Files         373      373              
  Lines       78136    78136              
==========================================
- Hits        52466    52457       -9     
- Misses      20973    20980       +7     
- Partials     4697     4699       +2

Impacted Files	Coverage Δ
sessionctx/variable/sysvar.go	`100% <100%> (ø)`	⬆️
sessionctx/variable/varsutil.go	`25.92% <50%> (ø)`	⬆️
ddl/session_pool.go	`82.75% <0%> (-10.35%)`	⬇️
store/tikv/scan.go	`73.94% <0%> (-3.37%)`	⬇️
ddl/delete_range.go	`73.54% <0%> (-1.59%)`	⬇️
expression/schema.go	`93.75% <0%> (-0.79%)`	⬇️
infoschema/infoschema.go	`77.63% <0%> (+1.31%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e499da9...1cde77b. Read the comment docs.

jackysp

Thanks for your contribution, @aliiohs !
Please add a test case, e.g. select @@log_bin;
Rest LGTM.

sessionctx/variable/sysvar.go

tidb-server/main.go

sessionctx/variable/sysvar.go

WangXiangUSTC · 2019-02-18T11:14:49Z

LGTM

aliiohs · 2019-02-19T02:53:30Z

@jackysp i already added the test case for 'log_bin'

zimulala · 2019-02-19T03:30:24Z

sessionctx/variable/varsutil.go

@@ -340,6 +340,15 @@ func ValidateSetSystemVar(vars *SessionVars, name string, value string) (string,
 			return "0", nil
 		}
 		return value, ErrWrongValueForVar.GenWithStackByArgs(name, value)
+	case LogBin:


Could we put it to line 335? Then we can remove line344-351.

LogBin need to return "ON" or "OFF", not "0" or "1"

@zimulala so i will merge 'LogBin' and 'TiDBEnableTablePartition'

No. I mean you can merge LogBin with GeneralLog. TiDBEnableTablePartition has the value of AUTO, which is different from LogBin.

The return value is "0" or “1”, is it expected? @zimulala

I think it's OK. We can handle LogBin like SQLLogBin. Then we can remove BoolToStatusStr.
We will handle #9357 in the next PR.

ok, i will change the code later. @zimulala

winkyao · 2019-02-19T07:13:02Z

sessionctx/variable/varsutil.go

@@ -348,7 +348,7 @@ func ValidateSetSystemVar(vars *SessionVars, name string, value string) (string,
 			return value, nil
 		}
 		return value, ErrWrongValueForVar.GenWithStackByArgs(name, value)
-	case TiDBEnableTablePartition:
+	case TiDBEnableTablePartition, LogBin:


If the log_bin == "2", the return value is "auto", is it expected?

@winkyao @zimulala I think I changed the return value to "0" and "1" is not a good way, so i want to keep it in independent case.

winkyao

LGTM, @jackysp PTAL

jackysp · 2019-02-20T02:19:21Z

executor/set_test.go

@@ -15,6 +15,7 @@ package executor_test

 import (
 	"context"
+	"github.com/pingcap/tidb/config"


Keep the sys libs seperate with the 3rd libs. Please move it down to line 20.

i already finished it

jackysp

LGTM

jackysp · 2019-02-20T03:19:30Z

/run-all-tests

WangXiangUSTC · 2019-02-20T06:57:53Z

/run-all-tests

aliiohs added 3 commits February 18, 2019 15:51

Support variable log_bin

62606d6

Support variable log_bin,Because the scope is not determined，so the…

3eb96d3

… test only contains session level

set ScopeNone as the scope of log_bin

b3af774

jackysp reviewed Feb 18, 2019

View reviewed changes

WangXiangUSTC reviewed Feb 18, 2019

View reviewed changes

sessionctx/variable/sysvar.go Outdated Show resolved Hide resolved

WangXiangUSTC reviewed Feb 18, 2019

View reviewed changes

sessionctx/variable/sysvar.go Outdated Show resolved Hide resolved

WangXiangUSTC added contribution This PR is from a community contributor. component/binlog labels Feb 18, 2019

aliiohs added 3 commits February 18, 2019 17:30

set `log_bin in setGlobalVars method

195eaa8

Support variable log_bin

af59973

add a Blank in Comment of variable 'LogBin'

b682f93

WangXiangUSTC reviewed Feb 18, 2019

View reviewed changes

tidb-server/main.go Outdated Show resolved Hide resolved

tidb-server/main.go Outdated Show resolved Hide resolved

aliiohs added 3 commits February 18, 2019 18:31

abstract a method transfer bool to status str ,like "ON" or "OFF"

6b8a504

add Comment for BoolToStatusStr

13d63e9

add Comment for BoolToStatusStr

8d8d596

WangXiangUSTC reviewed Feb 18, 2019

View reviewed changes

tidb-server/main.go Outdated Show resolved Hide resolved

WangXiangUSTC reviewed Feb 18, 2019

View reviewed changes

sessionctx/variable/sysvar.go Outdated Show resolved Hide resolved

aliiohs added 2 commits February 18, 2019 18:55

import Alias

4566842

please add a blank after ,

054cb18

WangXiangUSTC added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 18, 2019

jackysp changed the title ~~Support variable log_bin~~ *: support variable log_bin Feb 18, 2019

add a test case for 'log_bin'

feea00e

zimulala reviewed Feb 19, 2019

View reviewed changes

move merge case 'LogBin' to case 'TiDBEnableTablePartition'

f862b4c

winkyao reviewed Feb 19, 2019

View reviewed changes

aliiohs added 2 commits February 19, 2019 15:40

'LogBin' still keep an independent case

82e7be3

change LogBin Status from "ON" or "OFF" to "0" or "1".

fe01745

aliiohs force-pushed the support_log_bin_2019_02_18_1 branch from 533d989 to fe01745 Compare February 19, 2019 12:46

aliiohs added 2 commits February 19, 2019 20:47

Merge branch 'master' into support_log_bin_2019_02_18_1

c1c1748

change status of'LogBin' from 'on/off' to '0/1'.

65943a9

winkyao reviewed Feb 20, 2019

View reviewed changes

jackysp reviewed Feb 20, 2019

View reviewed changes

eep the sys libs seperate with the 3rd libs.

4f7b4b0

jackysp approved these changes Feb 20, 2019

View reviewed changes

Merge branch 'master' into support_log_bin_2019_02_18_1

bcbe263

WangXiangUSTC added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 20, 2019

Merge branch 'master' into support_log_bin_2019_02_18_1

889fbd9

Merge branch 'master' into support_log_bin_2019_02_18_1

1cde77b

ngaut merged commit 8f3c74c into pingcap:master Feb 20, 2019

aliiohs deleted the support_log_bin_2019_02_18_1 branch March 3, 2019 04:07

WangXiangUSTC mentioned this pull request Mar 11, 2019

*: support variable log_bin #9634

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: support variable `log_bin` #9343

*: support variable `log_bin` #9343

aliiohs commented Feb 18, 2019 •

edited by WangXiangUSTC

Loading

codecov-io commented Feb 18, 2019 •

edited

Loading

jackysp left a comment

WangXiangUSTC commented Feb 18, 2019

aliiohs commented Feb 19, 2019

zimulala Feb 19, 2019

aliiohs Feb 19, 2019

aliiohs Feb 19, 2019

zimulala Feb 19, 2019

aliiohs Feb 19, 2019

zimulala Feb 19, 2019

aliiohs Feb 19, 2019

winkyao Feb 19, 2019

aliiohs Feb 19, 2019 •

edited

Loading

winkyao left a comment

jackysp Feb 20, 2019

aliiohs Feb 20, 2019

jackysp left a comment

jackysp commented Feb 20, 2019

WangXiangUSTC commented Feb 20, 2019

*: support variable log_bin #9343

*: support variable log_bin #9343

Conversation

aliiohs commented Feb 18, 2019 • edited by WangXiangUSTC Loading

codecov-io commented Feb 18, 2019 • edited Loading

Codecov Report

jackysp left a comment

Choose a reason for hiding this comment

WangXiangUSTC commented Feb 18, 2019

aliiohs commented Feb 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aliiohs Feb 19, 2019 • edited Loading

Choose a reason for hiding this comment

winkyao left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jackysp left a comment

Choose a reason for hiding this comment

jackysp commented Feb 20, 2019

WangXiangUSTC commented Feb 20, 2019

*: support variable `log_bin` #9343

*: support variable `log_bin` #9343

aliiohs commented Feb 18, 2019 •

edited by WangXiangUSTC

Loading

codecov-io commented Feb 18, 2019 •

edited

Loading

aliiohs Feb 19, 2019 •

edited

Loading